HardyBarth: add phase voltages#30490
Merged
Merged
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Adds per-phase voltage reporting for the Hardy Barth eCB1 charger integration by implementing api.PhaseVoltages and reading the meter API’s demand voltage OBIS registers, aligning with the existing “demand-only” behavior used for currents/power in this device integration.
Changes:
- Implement
api.PhaseVoltagesforHardyBarth. - Add
Voltages()that returns L1/L2/L3 values fromobis.VoltageDemandL*viameterG().
premultiply
force-pushed
the
feature/hardybarth-voltages
branch
from
66bf292 to
86edf3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #30489 (which adds the
VoltageDemandOBIS codes).Implement
api.PhaseVoltagesfor the Hardy Barth eCB1 using the demand voltage registers (1-0:32/52/72.4.0) the meter API exposes. The eCB1 provides only demand (D=4) values, so this mirrors howCurrentsalready reads the.4.0registers.Once #30489 merges, this PR re-targets to
masterautomatically.