Skip to content

refactor: centralize and group OBIS codes#30489

Merged
premultiply merged 2 commits into
masterfrom
feature/meter-obis
Jun 4, 2026
Merged

refactor: centralize and group OBIS codes#30489
premultiply merged 2 commits into
masterfrom
feature/meter-obis

Conversation

@premultiply
Copy link
Copy Markdown
Member

@premultiply premultiply commented Jun 4, 2026

  • Move the OBIS codes used across meters into the shared obis package and regroup them by quantity (power / energy / current / voltage).
  • Harmonize naming: Import/Export, instantaneous as the unqualified default (OBIS D=7), Demand suffix for the last-average .4.0 registers (D=4), tariff suffix T1/T2 for energy.
  • Add VoltageDemand codes (kept here for a follow-up PR that adds HardyBarth phase voltages).

charger/hardybarth-ecb1

  • Switch to the renamed shared constants. No functional change.
  • Attention: The eCB1 meter API only exposes demand (D=4) and energy (D=8) registers, no instantaneous (D=7) values, so power/current use the Demand variants on purpose (see Hardy Barth eCB1/cPH1/cPH2 #778).

Copilot AI review requested due to automatic review settings June 4, 2026 11:06
@premultiply premultiply marked this pull request as draft June 4, 2026 11:07
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

This comment was marked as resolved.

@premultiply premultiply force-pushed the feature/meter-obis branch from 90b3425 to 98efc13 Compare June 4, 2026 11:11
@premultiply premultiply changed the title meter/obis: centralize OBIS codes; HardyBarth: add phase voltages refactor: centralize and group OBIS codes Jun 4, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@premultiply premultiply added the infrastructure Basic functionality label Jun 4, 2026
@premultiply premultiply self-assigned this Jun 4, 2026
@premultiply premultiply marked this pull request as ready for review June 4, 2026 11:18
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@premultiply premultiply merged commit 3119fc6 into master Jun 4, 2026
7 checks passed
@premultiply premultiply deleted the feature/meter-obis branch June 4, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Basic functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants