Templates: keep large numeric params parseable - #32528
Merged
Merged
Conversation
JSON numbers reach the config API as float64. Rendering them with %v switches to exponential notation above roughly a million, so 3493601102 became 3.493601102e+09, which no longer parses as an integer. A required int param with such a value was rejected as missing. Smaller values like a port or a phase count were unaffected, which is why this went unnoticed.
andig
enabled auto-merge (squash)
August 4, 2026 18:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A required int template param with a large value is rejected as missing.
JSON numbers reach the config API as float64.
RenderResultformats them with%v, which switches to exponential notation above roughly a million, so3493601102becomes3.493601102e+09.IsZeroparses that as 0 and therequired check fails:
Smaller values like a port or a phase count are unaffected, which is probably
why this went unnoticed. I ran into it with a ten digit device serial as a
template param.
Formats floats with
strconv.FormatFloat(v, 'f', -1, 64)instead and handlesfloat in the
Defaultsswitch. Two tests cover the formatting and theend-to-end required check: