spatulasnout#436
Closed
spatulasnout wants to merge 8 commits into
Closed
Conversation
defaulting to true. CLOEXEC is set in all cases except AttachFD, Popen, and Socketpair.
…work when BUILD_FOR_RUBY?
result is compared with WSAE... codes. Per http://msdn.microsoft.com/en-us/library/windows/desktop/ms737828%28v=vs.85%29.aspx Error codes set by Windows Sockets are not made available through the errno variable. Comparison of errno values with WSAE codes was causing EventMachine to spontaneously close socket connections when the errno value didn't match the expected WSAE codes.
Contributor
Author
|
Ugh, sorry. My first pull request. Only meant to be for commit 84b3d4d , not my entire branch. (I'd closed this, but haven't figured out how to create a pull request for just a single commit, so I've reopened it.) |
Contributor
|
I've cherry-picked the commit as ff811a8. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requesting pull for commit 84b3d4d:
Bug fix for OS_WIN32: Replaced errno with WSAGetLastError() where
result is compared with WSAE... codes.
Per http://msdn.microsoft.com/en-us/library/windows/desktop/ms737828%28v=vs.85%29.aspx
Error codes set by Windows Sockets are not made available through the
errno variable.
Comparison of errno values with WSAE codes was causing EventMachine
to spontaneously close socket connections when the errno value didn't
match the expected WSAE codes.