Skip to content

fix(security): from_reqwest leaks error details contradicting TM-LEAK-001 #38

@chaliy

Description

@chaliy

Problem

FetchError::from_reqwest() in error.rs:70 passes the raw reqwest error string through via RequestError(err.to_string()). Reqwest error messages can contain hostnames and URLs of internal services, contradicting TM-LEAK-001 which claims error messages do not reveal internal network topology.

The ConnectError variant Display is generic ("Failed to connect to server"), but the RequestError fallback path passes the full reqwest error string.

Impact

Low/Medium — internal hostnames could be exposed in error messages returned to callers.

Fix

Sanitize the reqwest error in the RequestError fallback to strip URL/hostname details.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions