fix(security): sanitize reqwest error messages to prevent hostname leakage#40
Merged
fix(security): sanitize reqwest error messages to prevent hostname leakage#40
Conversation
…akage from_reqwest() was passing raw reqwest error strings through RequestError(err.to_string()), which could contain internal hostnames or URL details. Now classifies errors by kind (redirect, body, decode) with generic messages. Closes #38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sanitize reqwest error messages in
from_reqwest()to prevent leaking internal hostnames.Why
FetchError::from_reqwest()was passing rawerr.to_string()throughRequestError, which could expose internal hostnames or URL details in error messages. This contradicts TM-LEAK-001.How
Risk
Closes #38
Checklist