Skip to content

add mysql support#165

Merged
hughess merged 4 commits intoevidence-dev:developfrom
moszutij:mysql-connector
Feb 1, 2022
Merged

add mysql support#165
hughess merged 4 commits intoevidence-dev:developfrom
moszutij:mysql-connector

Conversation

@moszutij
Copy link
Copy Markdown
Contributor

Resolves #94

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/evidence-dev/evidence-docs/8aHRzDvnvcQNYyVtxJHBNfNaJujL
✅ Preview: https://evidence-docs-git-fork-moszutij-mysql-connector-evidence-dev.vercel.app

@hughess
Copy link
Copy Markdown
Member

hughess commented Feb 1, 2022

Hey @moszutij, this looks great! Thanks for contributing!! 🎉 ❤️

I have a few minor things to update (mostly based on some recent changes we made to our other connectors). Can you check if I have access to commit to your PR (this checkbox)?

I tested it with a Google Cloud SQL instance of MySQL 8.0 and it worked well. The only thing that seemed off was a known issue with the decimal data type (sidorares/node-mysql2#795), so I added their recommended solution to the config.

@moszutij
Copy link
Copy Markdown
Contributor Author

moszutij commented Feb 1, 2022

Hi @hughess, Thanks for taking the time to review the changes and making the improvements, much appreciated. Regarding, access to commit my PR, I have the 'Allow edits by maintainers' checked.

Screenshot 2022-02-01 at 16 54 46

If there is still a problem, just grab me on Slack and we can review the settings over a screen share session.

@hughess
Copy link
Copy Markdown
Member

hughess commented Feb 1, 2022

@moszutij it's all working now - thanks!!

@hughess hughess merged commit 2aae24d into evidence-dev:develop Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MySQL Support

2 participants