Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/evidence-dev/evidence-docs/8aHRzDvnvcQNYyVtxJHBNfNaJujL |
|
Hey @moszutij, this looks great! Thanks for contributing!! 🎉 ❤️ I have a few minor things to update (mostly based on some recent changes we made to our other connectors). Can you check if I have access to commit to your PR (this checkbox)? I tested it with a Google Cloud SQL instance of MySQL 8.0 and it worked well. The only thing that seemed off was a known issue with the decimal data type (sidorares/node-mysql2#795), so I added their recommended solution to the config. |
|
Hi @hughess, Thanks for taking the time to review the changes and making the improvements, much appreciated. Regarding, access to commit my PR, I have the 'Allow edits by maintainers' checked. If there is still a problem, just grab me on Slack and we can review the settings over a screen share session. |
|
@moszutij it's all working now - thanks!! |

Resolves #94