[FEATURE] Create new ViewHelper <register:uri.action>#281
Merged
Conversation
koehnlein
force-pushed
the
feature/viewhelper-url
branch
from
3bedc5f to
1e6dd56
Compare
koehnlein
changed the title
<register:uri.action>
koehnlein
changed the title
<register:uri.action><register:uri.action>
Contributor
Author
|
@evoWeb Would be nice to get some feedback. 🙂 To avoid duplicate code, I created |
Collaborator
|
I like the approach to integrate tests and having a clear idea to make sure that the viewhelper are working as expected. That is nice to see. Also I have one wish. Please revert the commit [64c2805] with the trait. I'd rather see duplicate code then traits. Also the link usually has one argument more than the uri. Having a look on how the core action viewhelpers are differing a trait is not that helpful either. |
This reverts commit 64c2805.
Contributor
Author
|
@garbast The commit is reverted and the trait does not exist anymore |
Collaborator
|
Thank you for your work on adding the viewhelper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new ViewHelper
<register:uri.action>similar to existing<register.link.action>While the functionality of the existing ViewHelper keeps untouched, the new ViewHelper only returns the URL instead of a full
<a>tag.To ensure, the functionality of both ViewHelpers does not break, functional tests for both ViewHelpers have been added.
Resolve #280