Skip to content

fix: panic on Archive event due to unchecked type assertion - #159

Open
FlavioPulli wants to merge 1 commit into
evolution-foundation:developfrom
FlavioPulli:fix/archive-event-panic-develop
Open

fix: panic on Archive event due to unchecked type assertion#159
FlavioPulli wants to merge 1 commit into
evolution-foundation:developfrom
FlavioPulli:fix/archive-event-panic-develop

Conversation

@FlavioPulli

@FlavioPulli FlavioPulli commented Aug 4, 2026

Copy link
Copy Markdown

myEventHandler builds postMap without a "data" key, so the *events.Archive case asserting postMap["data"].(map[string]interface{}) (pkg/whatsmeow/service/whatsmeow.go:1820) panics the whole process whenever a chat is archived or unarchived on the paired phone.

Every other case that reads postMap["data"] guards the key first (Message, Receipt, etc.) — Archive was the only one missing the guard. This builds the data payload map directly, preserving the exact webhook shape.

How to reproduce: pair an instance, archive any chat on the phone → the process dies with panic: interface conversion: interface {} is nil, not map[string]interface {}.


Retargeted to develop (replaces #125), as requested by @iagocotta in #128 (comment).

Note that main and develop have no common ancestor — the GitHub API refuses to compare them (No common ancestor between main and develop) — so the base branch of the original PR could not simply be edited. This branch was created from develop and the commit cherry-picked onto it.

Verified on this branch: go build ./... and go vet ./... both pass.

Summary by Sourcery

Bug Fixes:

  • Fix Archive event handling that assumed an existing data payload and crashed on chat archive/unarchive.

myEventHandler builds postMap without a "data" key, so the Archive case
asserting postMap["data"].(map[string]interface{}) panics the whole
process whenever a chat is archived or unarchived on the paired phone.
Every other case that reads postMap["data"] guards the key first (e.g.
Message, Receipt); Archive was the only one missing it. Build the data
payload map directly, preserving the exact webhook shape.
@sourcery-ai

sourcery-ai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fixes a panic in the Archive event handler by eliminating an unsafe type assertion on the webhook payload and constructing the data map directly.

File-Level Changes

Change Details Files
Remove unsafe type assertion on the Archive event webhook payload and build the data map directly to avoid panics when chats are archived or unarchived.
  • Replace type assertion on postMap["data"] with direct construction of a new map[string]interface{} for Archive events.
  • Populate the Archive event payload map with JID, Timestamp, Action, and FromFullSync fields instead of mutating a preexisting map.
  • Add an explanatory comment describing the previous panic condition and why the payload is now built directly.
pkg/whatsmeow/service/whatsmeow.go

Possibly linked issues

  • #: PR changes Archive handler to construct the data map safely, removing the panic described in the issue.
  • #Bug: API /chat/archive - interface conversion: interface {} is *events.Archive, not map[string]interface {} (v0.7.2): PR fixes the unchecked type assertion on Archive events that causes the panic reported in the issue.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant