test: fix TestExecuteFiresEvents by julienrbrt · Pull Request #136 · evstack/ev-abci

julienrbrt · 2025-06-17T08:51:16Z

Summary by CodeRabbit

Tests
- Improved the construction of test data in event firing tests to better align with expected validator formats and signing procedures.

coderabbitai · 2025-06-17T08:51:22Z

Walkthrough

The test TestExecuteFiresEvents in adapter_test.go was updated to construct and sign a SignedHeader using CometBFT-compatible validator and signature types. The proposer address is now derived from a validator's address, and the signature process uses CometBFT serialization and signature wrapping.

Changes

File(s)	Change Summary
pkg/adapter/adapter_test.go	Updated test setup to use CometBFT-compatible validator address, header serialization, and signatures.

Poem

In the warren of code, a header takes flight,
With validator’s address now perfectly right.
Signatures wrapped, the test hops anew,
CometBFT’s format—precise and true.
With every event, the adapter’s delight,
The rabbits rejoice in code shining bright!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d328eae and 254744d.

📒 Files selected for processing (1)

pkg/adapter/adapter_test.go (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

pkg/adapter/adapter_test.go

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: lint / golangci-lint
GitHub Check: test / Run Unit Tests
GitHub Check: Test with Rollkit Chain

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

pkg/adapter/adapter_test.go (1)
89-99: Minor: simplify PubKey conversion

You can avoid the temporary cometBftPubKey variable and the raw-byte detour:
-	pubKeyRaw, err := pubKey.Raw()
-	require.NoError(t, err)
-	cometBftPubKey = pubKeyRaw
+	cometBftPubKey := tmcryptoed25519.PubKey(pubKey[0:]) // direct cast to CometBFT type
This removes one allocation and keeps the intent clear.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2cc9b71 and d328eae.

📒 Files selected for processing (1)

pkg/adapter/adapter_test.go (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

pkg/adapter/adapter_test.go (1)

pkg/cometcompat/signer.go (1)

PayloadProvider (10-33)

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: lint / golangci-lint
GitHub Check: test / Run Unit Tests
GitHub Check: Test with Rollkit Chain

🔇 Additional comments (1)

pkg/adapter/adapter_test.go (1)

113-121: Signature type mismatch may lead to inconsistent data in the store

signedHeader.Signature is set to the raw []byte (sig), while SaveBlockData receives *types.Signature.
If types.SignedHeader.Signature is also expected to be a types.Signature, this asymmetry could break later verification steps.

Please confirm the expected types; if necessary:
-	signedHeader := &types.SignedHeader{
-		Header:    header,
-		Signer:    signer,
-		Signature: sig,
-	}
+	signedHeader := &types.SignedHeader{
+		Header:    header,
+		Signer:    signer,
+		Signature: sigT,
+	}
and drop the &sigT argument when calling SaveBlockData.

* test: fix TestExecuteFiresEvents * fix test * lint

test: fix TestExecuteFiresEvents

c1aad03

fix test

d328eae

julienrbrt marked this pull request as ready for review June 17, 2025 11:41

julienrbrt requested a review from randygrok June 17, 2025 11:41

julienrbrt mentioned this pull request Jun 17, 2025

IBC CI test + Fix block results tests #133

Closed

2 tasks

coderabbitai Bot reviewed Jun 17, 2025

View reviewed changes

Comment thread pkg/adapter/adapter_test.go

lint

254744d

julienrbrt enabled auto-merge (squash) June 17, 2025 15:33

randygrok approved these changes Jun 17, 2025

View reviewed changes

julienrbrt merged commit fa80885 into main Jun 17, 2025
10 checks passed

julienrbrt deleted the julien/test branch June 17, 2025 16:30

coderabbitai Bot mentioned this pull request Jun 17, 2025

test: fix TestBlockSearch_Success and TestCommit_VerifyCometBFTLightClientCompatibility_MultipleBlocks #137

Merged

julienrbrt added a commit that referenced this pull request Jun 17, 2025

test: fix TestExecuteFiresEvents (#136)

88a7fa3

* test: fix TestExecuteFiresEvents * fix test * lint

chatton pushed a commit that referenced this pull request Oct 7, 2025

test: fix TestExecuteFiresEvents (#136)

4995268

* test: fix TestExecuteFiresEvents * fix test * lint

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: fix TestExecuteFiresEvents#136

test: fix TestExecuteFiresEvents#136
julienrbrt merged 3 commits intomainfrom
julien/test

julienrbrt commented Jun 17, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 17, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

julienrbrt commented Jun 17, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

julienrbrt commented Jun 17, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 17, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)