Skip to content

test: fix TestExecuteFiresEvents #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 3 commits into from
Jun 17, 2025
Merged

test: fix TestExecuteFiresEvents #136

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1aad03
test: fix TestExecuteFiresEvents
julienrbrt Jun 17, 2025
d328eae
fix test
julienrbrt Jun 17, 2025
254744d
lint
julienrbrt Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 28 additions & 15 deletions pkg/adapter/adapter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (

"cosmossdk.io/log"
abci "github.com/cometbft/cometbft/abci/types"
tmcryptoed25519 "github.com/cometbft/cometbft/crypto/ed25519"
cmtpubsub "github.com/cometbft/cometbft/libs/pubsub"
cmtquery "github.com/cometbft/cometbft/libs/pubsub/query"
"github.com/cometbft/cometbft/mempool"
Expand All @@ -22,11 +23,11 @@ import (
"github.com/stretchr/testify/require"

"github.com/rollkit/rollkit/types"

"github.com/rollkit/go-execution-abci/pkg/cometcompat"
)

func TestExecuteFiresEvents(t *testing.T) {
t.Skip()

timestamp := time.Now()
myTxs := [][]byte{{0x01}, {0x02}}
myExecResult := []*abci.ExecTxResult{{Code: 0, Data: []byte{0}}, {Code: 0, Data: []byte{1}}}
Expand Down Expand Up @@ -85,26 +86,38 @@ func TestExecuteFiresEvents(t *testing.T) {
adapter.MempoolIDs = newMempoolIDs()
adapter.Mempool = &mempool.NopMempool{}

_, pubKey, err := crypto.GenerateEd25519Key(nil)
var cometBftPubKey tmcryptoed25519.PubKey
privKey, pubKey, err := crypto.GenerateEd25519Key(nil)
require.NoError(t, err)

address, err := pubKey.Raw()
// mimic cometbft validator set settings\
// otherwise .Address is 32 bytes long while cometbft expects 20 bytes
pubKeyRaw, err := pubKey.Raw()
require.NoError(t, err)
cometBftPubKey = pubKeyRaw
val := cmtypes.NewValidator(cometBftPubKey, 1)

var sig types.Signature = make([]byte, 32)
header := types.Header{
BaseHeader: types.BaseHeader{Height: 2, Time: uint64(time.Now().UnixNano())},
ProposerAddress: val.Address,
AppHash: []byte("apphash1"),
}

headerBz, err := cometcompat.PayloadProvider()(&header)
require.NoError(t, err)

sig, err := privKey.Sign(headerBz)
require.NoError(t, err)
sigT := types.Signature(sig)

signer, err := types.NewSigner(pubKey)
require.NoError(t, err)
signedHeader := &types.SignedHeader{
Header: types.Header{
BaseHeader: types.BaseHeader{Height: 2, Time: uint64(time.Now().UnixNano())},
ProposerAddress: address,
AppHash: []byte("apphash1"),
},
Signer: types.Signer{
Address: address,
PubKey: pubKey,
},
Header: header,
Signer: signer,
Signature: sig,
}
require.NoError(t, adapter.RollkitStore.SaveBlockData(ctx, signedHeader, &types.Data{Txs: make(types.Txs, 0)}, &sig))
require.NoError(t, adapter.RollkitStore.SaveBlockData(ctx, signedHeader, &types.Data{Txs: make(types.Txs, 0)}, &sigT))
require.NoError(t, adapter.Store.SaveState(ctx, stateFixture()))

// when
Expand Down