chore: run go fix

[julienrbrt]

Overview

[gemini-code-assist]

Summary of Changes

Hello @julienrbrt, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors various parts of the codebase to utilize modern Go language features and standard library functions. The changes, consistent with what an automated go fix tool might apply, aim to improve code readability, conciseness, and maintainability by replacing older patterns with more idiomatic and efficient Go constructs. The impact is a cleaner and more up-to-date codebase without altering core logic or functionality.

Highlights

• Code Modernization: The pull request primarily focuses on modernizing Go code by leveraging newer language features and standard library functions, aligning with best practices often enforced by go fix.
• Simplified Min/Max Calculations: Replaced manual minLen calculations with the built-in min() function in bitmap.go and net.go, and simplified limit calculation using max() in mempool.go.
• Type System Enhancements: Updated function parameters from interface{} to the more concise any type in params.go and genesis_helpers.go, and map declarations in start.go.
• Idiomatic Loop Syntax: Adopted more idiomatic Go loop syntax, changing for i := 0; i < len(slice); i++ to for i := range slice or for range count where appropriate, as seen in tx.go and attester_cmd.go.
• Standard Library Usage: Introduced the slices package for sorting in blocks.go, replacing a custom sort.Slice implementation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• modules/network/keeper/bitmap.go
  • Simplified minLen calculation using the min function in OR and AND methods.
• modules/network/types/params.go
  • Updated validateEpochLength, validateQuorumFraction, validateMinParticipation, validatePruneAfter, and validateSignMode functions to use any instead of interface{} for their input parameters.
• pkg/rpc/core/blocks.go
  • Imported the slices package.
  • Replaced sort.Slice with slices.Sort for ascending order sorting of results.
• pkg/rpc/core/mempool.go
  • Refactored the limit calculation to use max(cmtmath.MinInt(*limitPtr, limit), 0) for conciseness.
• pkg/rpc/core/net.go
  • Simplified the calculation of the end index for genesis chunks using the min function.
• pkg/rpc/core/tx.go
  • Updated the loop in hashList to use for i := range txs for iterating over transaction hashes.
• server/attester_cmd.go
  • Modernized loop syntax in joinAttesterSet from for i := 0; i < retries; i++ to for range retries.
  • Modernized loop syntax in broadcastTx from for i := 0; i < retries; i++ to for i := range retries.
• server/genesis_helpers.go
  • Updated the getJSONTag function parameter from interface{} to any.
• server/start.go
  • Changed the map type declaration from map[string]interface{} to map[string]any{} when unsetting pruning keys.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request successfully modernizes the codebase by applying Go-specific fixes and patterns introduced in recent Go versions (up to Go 1.22+ features like for range on integers and Go 1.21+ built-ins like min/max and the slices package). The changes improve readability and performance (e.g., slices.Sort is generally faster than sort.Slice). I have one suggestion to further leverage the min built-in in mempool.go to remove an unnecessary library dependency.