fix: reduce resources consumption in ci - #2462
Conversation
WalkthroughThe integration test Changes
Sequence Diagram(s)sequenceDiagram
participant Sequencer
participant FullNode1
participant FullNode2
participant Test
Test->>Sequencer: Start sequencer node
Sequencer-->>Test: Wait for first block
Test->>FullNode1: Start full node 1
Test->>FullNode2: Start full node 2
Test->>Sequencer: Inject transaction
Sequencer-->>FullNode1: Gossip transaction/block
Sequencer-->>FullNode2: Gossip transaction/block
FullNode1-->>Test: Reach target block height
FullNode2-->>Test: Reach target block height
Test->>Sequencer: Shutdown
Test->>FullNode1: Shutdown
Test->>FullNode2: Shutdown
Test-->>Test: Assert all nodes synchronized
Assessment against linked issues
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (2)**/*_test.goInstructions used from: Sources:
**/*.goInstructions used from: Sources:
🧠 Learnings (2)📓 Common learningsnode/full_node_integration_test.go (2)⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
🔇 Additional comments (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
The latest Buf updates on your PR. Results from workflow CI and Release / buf-check (pull_request).
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @tac0turtle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on optimizing the Continuous Integration (CI) pipeline by reducing resource consumption and improving test consistency. It achieves this by modifying an existing integration test to use fewer simulated nodes and adjusting timeouts to make the test more reliable.
Highlights
- CI Resource Optimization: Reduced the number of simulated nodes in the
TestTxGossipingMultipleNodesNoDAintegration test from 4 (1 sequencer, 3 full nodes) to 3 (1 sequencer, 2 full nodes). This aims to decrease resource consumption during CI runs. - Test Consistency Improvement: Adjusted parameters within the
TestTxGossipingMultipleNodesNoDAintegration test to improve its consistency. This includes reducing the number of blocks to wait for from 5 to 3, and increasing theshutdownAndWaittimeout from 5 seconds to 10 seconds, allowing more time for graceful node shutdown.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2462 +/- ##
==========================================
- Coverage 73.15% 73.09% -0.07%
==========================================
Files 68 68
Lines 6542 6542
==========================================
- Hits 4786 4782 -4
- Misses 1359 1362 +3
- Partials 397 398 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Overview
This pr reduces the amount of nodes we run and increases the timeout in order to try to make ci more consistent
closes #2425
Summary by CodeRabbit