refactor: allow fetching easily first da included height#2614
Merged
julienrbrt merged 4 commits intomainfrom Sep 1, 2025
Merged
refactor: allow fetching easily first da included height#2614julienrbrt merged 4 commits intomainfrom
julienrbrt merged 4 commits intomainfrom
Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow CI and Release / buf-check (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2614 +/- ##
==========================================
- Coverage 71.13% 71.07% -0.06%
==========================================
Files 73 73
Lines 7631 7644 +13
==========================================
+ Hits 5428 5433 +5
- Misses 1750 1756 +6
- Partials 453 455 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tac0turtle
previously approved these changes
Sep 1, 2025
Contributor
tac0turtle
left a comment
There was a problem hiding this comment.
much better UX than looking at DA for the info
tac0turtle
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes: #2117
Execution environments will then be able to poll that data from the nodes if wanted (no need to do that here, can be done in at genesis parsing).