Skip to content

refactor: allow fetching easily first da included height#2614

Merged
julienrbrt merged 4 commits intomainfrom
julien/simplify-genesis
Sep 1, 2025
Merged

refactor: allow fetching easily first da included height#2614
julienrbrt merged 4 commits intomainfrom
julien/simplify-genesis

Conversation

@julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 29, 2025

Overview

Closes: #2117

  • Remove unused genesis helpers (execution environment should do that)
  • Rename GenesisDaStartTime to simply StartTime, as it is effectively the network start time
  • Add rpc to fetch first da included height
  • Save first da included height in a separate key
  • Rename some confusing terms and add go doc.

Execution environments will then be able to poll that data from the nodes if wanted (no need to do that here, can be done in at genesis parsing).

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2025

The latest Buf updates on your PR. Results from workflow CI and Release / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedSep 1, 2025, 9:09 AM

@julienrbrt julienrbrt marked this pull request as ready for review August 29, 2025 15:56
@julienrbrt julienrbrt requested review from alpe and tac0turtle August 29, 2025 15:56
@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 77.08333% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.07%. Comparing base (a2714aa) to head (d41a832).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
block/manager.go 54.54% 8 Missing and 2 partials ⚠️
block/da_includer.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2614      +/-   ##
==========================================
- Coverage   71.13%   71.07%   -0.06%     
==========================================
  Files          73       73              
  Lines        7631     7644      +13     
==========================================
+ Hits         5428     5433       +5     
- Misses       1750     1756       +6     
- Partials      453      455       +2     
Flag Coverage Δ
combined 71.07% <77.08%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tac0turtle
tac0turtle previously approved these changes Sep 1, 2025
Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better UX than looking at DA for the info

@julienrbrt julienrbrt merged commit 017d6d4 into main Sep 1, 2025
34 of 37 checks passed
@github-project-automation github-project-automation bot moved this to Done in Evolve Sep 1, 2025
@julienrbrt julienrbrt deleted the julien/simplify-genesis branch September 1, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Feature Request]: genesis should poll DA for height

2 participants