-
Notifications
You must be signed in to change notification settings - Fork 247
fix(docs): remove blog link from sidebar to fix 404 #3014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The Blog section in the sidebar referenced /blog/overview but the blog directory was never created. Comment out the sidebar entry to match the already-commented nav entry. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @tac0turtle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a 404 error by commenting out the 'Blog' section in the documentation sidebar. This section previously linked to a non-existent Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
|
Claude finished @tac0turtle's task in 1m 19s —— View job Code Review Complete ✅
Review SummaryThis PR correctly addresses a 404 error by commenting out the Blog sidebar entry. The change is clean and appropriate, but I've identified related documentation that should also be updated for full consistency. ✅ What's Good
📋 Observations & Recommendations1. Documentation Inconsistencies (Low Priority)The blog directory is still referenced in documentation files as if it exists:
Recommendation: For complete consistency, these references should also be removed or updated to reflect that the blog section is not currently available. This is not critical since these are internal documentation files, but it would prevent future confusion. Fix documentation references → 2. Configuration Completeness ✅I verified that:
🎯 VerdictApproved - This is a straightforward, correct fix for the 404 error. The change:
The optional documentation cleanup mentioned above is nice-to-have but not required for this PR. Files Reviewed: |
julienrbrt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request successfully addresses the 404 error by commenting out the non-existent blog link in the sidebar, maintaining consistency with the already commented-out navigation entry. This is a straightforward and effective fix for the immediate issue.
| // { | ||
| // text: "Blog", | ||
| // collapsed: true, | ||
| // items: [{ text: "Overview", link: "/blog/overview" }], | ||
| // }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting out code, even for consistency with other commented-out sections, can lead to technical debt if the feature is not planned for re-introduction soon. If the blog section is not intended to be re-enabled in the near future, consider removing this block entirely to keep the configuration clean and reduce clutter. If it is a temporary disablement, adding a comment explaining the future intent would be beneficial.
|
* main: fix(docs): remove blog link from sidebar to fix 404 (#3014) build(deps): Bump github.com/cometbft/cometbft from 0.38.20 to 0.38.21 in /execution/evm/test in the go_modules group across 1 directory (#3011) refactor: use slices.Contains to simplify code (#3010) chore: Bump mermaid version and dependencies (#3009) chore: Bump github.com/consensys/gnark-crypto only (#3008) test: evm contract interaction (#3006) chore: remove redundant log (#3007) fix: return values correctly not nil (#3004) feat: expose execution client params to ev-node (#2982)
* main: fix(docs): remove blog link from sidebar to fix 404 (#3014) build(deps): Bump github.com/cometbft/cometbft from 0.38.20 to 0.38.21 in /execution/evm/test in the go_modules group across 1 directory (#3011) refactor: use slices.Contains to simplify code (#3010) chore: Bump mermaid version and dependencies (#3009) chore: Bump github.com/consensys/gnark-crypto only (#3008) test: evm contract interaction (#3006) chore: remove redundant log (#3007) fix: return values correctly not nil (#3004) feat: expose execution client params to ev-node (#2982) feat(tracing): HTTP propagation (#3000) fix: deploy docs token (#3003) feat(tracing): add store tracing (#3001) feat: p2p exchange wrapper (#2855) build(deps): Bump the all-go group across 5 directories with 5 updates (#2999) feat(tracing): adding forced inclusion tracing (#2997) chore: update calculator for strategies (#2995) chore: adding tracing for da submitter (#2993) feat(tracing): part 10 da retriever tracing (#2991) chore: add da posting strategy to docs (#2992)
The Blog section in the sidebar referenced /blog/overview but the blog directory was never created. Comment out the sidebar entry to match the already-commented nav entry.
Overview