chore: demote warn log as debug

[julienrbrt]

Overview

Avoid getting those strict warning, they are less relevant, because we are decoding data sometimes first.

[coderabbitai]

Warning

Rate limit exceeded

@julienrbrt has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 25 minutes and 55 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8c656e70-d4b9-4492-b493-9b945774067a

📥 Commits

Reviewing files that changed from the base of the PR and between 459f3c9 and c69037d.

📒 Files selected for processing (1)

• block/internal/syncing/da_retriever.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch julien/strict

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
✅ passed	⏩ skipped	✅ passed	✅ passed	Mar 24, 2026, 4:17 PM

[claude]

Claude finished @julienrbrt's task in 43s —— View job

---

Code Review

• Gather context and read changed file
• Analyze the diff and provide review

---

Summary: The PR demotes a Warn log to Debug at block/internal/syncing/da_retriever.go:258 in tryDecodeHeader.

The change is correct and well-motivated. Here's the reasoning:

When separate header and data namespaces are used, processBlobs iterates over all blobs and calls tryDecodeHeader on each one — including blobs that are actually data blobs. In strict mode, data blobs will inevitably fail UnmarshalDAEnvelope, which previously emitted a Warn-level log. This was a false alarm: the failure is expected behavior, not an error condition. Demoting to Debug eliminates log noise that could mislead operators.

The comment added at line 291–293 also clarifies the intent for future readers:

// no need to print warnings, as tryDecodeHeader could try to decode data first, which will show this warning.
r.logger.Debug().Msg("strict mode: rejecting block that is not a fully valid envelope")

One minor observation: The Warn log at line 257–259 (strict mode rejecting non-envelope blob) is now Debug, but the log at line 258 still includes .Err(err). Since this path is now expected/routine for data blobs, including the error object may add minor noise even at Debug level — but this is a very minor point and not worth blocking on.

No issues found. The change is minimal, focused, and correct. ✓

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.13%. Comparing base (1023109) to head (c69037d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3198      +/-   ##
==========================================
- Coverage   61.14%   61.13%   -0.01%     
==========================================
  Files         117      117              
  Lines       12082    12082              
==========================================
- Hits         7387     7386       -1     
- Misses       3868     3870       +2     
+ Partials      827      826       -1     

Flag	Coverage Δ
combined	61.13% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.