chore: prep apps/evm v1.2.2 and apps/testapp v1.1.5 - #3410
Conversation
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
📝 WalkthroughWalkthroughThe EVM and test application Go modules update their ev-node dependency requirements. The EVM module also updates the ev-node EVM execution dependency while retaining the existing core version. Changesev-node dependency updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/evm/go.mod`:
- Around line 7-9: Align the ev-node, core, and execution/evm dependency
versions in go.mod so the apps/evm/server proxy path uses compatible RPC
behavior. Then run go test ./... and verify
TestForceInclusionServer_ProxyToExecutionRPC returns a successful response
without a JSON-RPC error.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4ff493d8-55d1-447a-95a1-9bd0b3a136ec
⛔ Files ignored due to path filters (2)
apps/evm/go.sumis excluded by!**/*.sumapps/testapp/go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
apps/evm/go.modapps/testapp/go.mod
| github.com/evstack/ev-node v1.2.2 | ||
| github.com/evstack/ev-node/core v1.1.0 | ||
| github.com/evstack/ev-node/execution/evm v1.1.0 | ||
| github.com/evstack/ev-node/execution/evm v1.1.1 |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
cd apps/evm
go list -m -f '{{.Path}} {{.Version}}' \
github.com/evstack/ev-node \
github.com/evstack/ev-node/core \
github.com/evstack/ev-node/execution/evm
go test ./...Repository: evstack/ev-node
Length of output: 1006
Fix the failing apps/evm/server test before merging.
The mixed ev-node, core, and execution/evm versions compile together, but go test ./... still fails in apps/evm/server with TestForceInclusionServer_ProxyToExecutionRPC: the proxy request returns a non-nil JSON-RPC error.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/evm/go.mod` around lines 7 - 9, Align the ev-node, core, and
execution/evm dependency versions in go.mod so the apps/evm/server proxy path
uses compatible RPC behavior. Then run go test ./... and verify
TestForceInclusionServer_ProxyToExecutionRPC returns a successful response
without a JSON-RPC error.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3410 +/- ##
==========================================
+ Coverage 62.29% 62.32% +0.03%
==========================================
Files 120 120
Lines 13461 13461
==========================================
+ Hits 8385 8390 +5
+ Misses 4133 4129 -4
+ Partials 943 942 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Overview
Summary by CodeRabbit