Skip to content

chore: prep apps/evm v1.2.2 and apps/testapp v1.1.5 - #3410

Merged
tac0turtle merged 1 commit into
mainfrom
release/apps-v1.2.2
Jul 27, 2026
Merged

chore: prep apps/evm v1.2.2 and apps/testapp v1.1.5#3410
tac0turtle merged 1 commit into
mainfrom
release/apps-v1.2.2

Conversation

@tac0turtle

@tac0turtle tac0turtle commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Overview

Summary by CodeRabbit

  • Bug Fixes
    • Updated application components to incorporate the latest maintenance improvements from the underlying platform.
    • Improved consistency across EVM and test application environments.

@github-actions

Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed⏩ skippedJul 27, 2026, 10:09 AM

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The EVM and test application Go modules update their ev-node dependency requirements. The EVM module also updates the ev-node EVM execution dependency while retaining the existing core version.

Changes

ev-node dependency updates

Layer / File(s) Summary
Update application requirements
apps/evm/go.mod, apps/testapp/go.mod
The applications update github.com/evstack/ev-node to v1.2.2; the EVM application updates execution/evm to v1.1.1 and retains core at v1.1.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: julienrbrt

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is effectively empty and does not provide the required overview, context, goal, or rationale. Add an Overview that explains the change, its purpose, and rationale, and include any related issue reference or tl;dr.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: version prep for apps/evm and apps/testapp.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/apps-v1.2.2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/evm/go.mod`:
- Around line 7-9: Align the ev-node, core, and execution/evm dependency
versions in go.mod so the apps/evm/server proxy path uses compatible RPC
behavior. Then run go test ./... and verify
TestForceInclusionServer_ProxyToExecutionRPC returns a successful response
without a JSON-RPC error.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4ff493d8-55d1-447a-95a1-9bd0b3a136ec

📥 Commits

Reviewing files that changed from the base of the PR and between 644b05e and 7e72069.

⛔ Files ignored due to path filters (2)
  • apps/evm/go.sum is excluded by !**/*.sum
  • apps/testapp/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • apps/evm/go.mod
  • apps/testapp/go.mod

Comment thread apps/evm/go.mod
Comment on lines +7 to +9
github.com/evstack/ev-node v1.2.2
github.com/evstack/ev-node/core v1.1.0
github.com/evstack/ev-node/execution/evm v1.1.0
github.com/evstack/ev-node/execution/evm v1.1.1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

cd apps/evm
go list -m -f '{{.Path}} {{.Version}}' \
  github.com/evstack/ev-node \
  github.com/evstack/ev-node/core \
  github.com/evstack/ev-node/execution/evm
go test ./...

Repository: evstack/ev-node

Length of output: 1006


Fix the failing apps/evm/server test before merging.

The mixed ev-node, core, and execution/evm versions compile together, but go test ./... still fails in apps/evm/server with TestForceInclusionServer_ProxyToExecutionRPC: the proxy request returns a non-nil JSON-RPC error.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/evm/go.mod` around lines 7 - 9, Align the ev-node, core, and
execution/evm dependency versions in go.mod so the apps/evm/server proxy path
uses compatible RPC behavior. Then run go test ./... and verify
TestForceInclusionServer_ProxyToExecutionRPC returns a successful response
without a JSON-RPC error.

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.32%. Comparing base (644b05e) to head (7e72069).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3410      +/-   ##
==========================================
+ Coverage   62.29%   62.32%   +0.03%     
==========================================
  Files         120      120              
  Lines       13461    13461              
==========================================
+ Hits         8385     8390       +5     
+ Misses       4133     4129       -4     
+ Partials      943      942       -1     
Flag Coverage Δ
combined 62.32% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tac0turtle
tac0turtle merged commit 1f8b332 into main Jul 27, 2026
57 of 58 checks passed
@tac0turtle
tac0turtle deleted the release/apps-v1.2.2 branch July 27, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant