Skip to content

chore: bump lumen to reth 1.6.0#24

Merged
tac0turtle merged 2 commits intomainfrom
marko/v1.6.0
Jul 23, 2025
Merged

chore: bump lumen to reth 1.6.0#24
tac0turtle merged 2 commits intomainfrom
marko/v1.6.0

Conversation

@tac0turtle
Copy link
Contributor

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Refactoring

Related Issues

Fixes #(issue)

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Testing

Additional Notes

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @tac0turtle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on a significant dependency upgrade, moving the project's core components to the latest stable version of the Reth framework (1.6.0). This involves updating a wide array of related alloy and revm crates, along with general dependency cleanup and minor API adjustments to align with the new framework version.

Highlights

  • Reth Framework Upgrade: I've bumped the core Reth framework dependencies from version 1.5.0 to 1.6.0. This is reflected across all reth-* crates in Cargo.toml and Cargo.lock, now pointing to the v1.6.0 tag in the Reth repository.
  • Alloy Crate Updates: Numerous alloy-* crates have received version updates, including alloy-chains (0.2.4 -> 0.2.6), alloy-consensus (1.0.17 -> 1.0.23), alloy-evm (0.13.0 -> 0.15.0), and many others, indicating a general refresh of the Alloy ecosystem dependencies.
  • REVM Crate Updates: The revm and related revm-* crates have also been updated, with revm moving from 27.0.1 to 27.0.3, and various sub-crates receiving minor and patch bumps, reflecting improvements or bug fixes in the EVM execution layer.
  • API Adjustments: The bin/lumen/src/attributes.rs file has been updated to remove references to the UnsupportedLocalAttributes trait. This suggests a refactoring or removal of this specific API in the newer Reth version, simplifying the attribute handling.
  • General Dependency Housekeeping: Beyond the major framework updates, several other Rust dependencies have been updated (e.g., strum, rand, clap, tokio, serde_json), and some unused dependencies (bstr, console, encode_unicode, similar, similar-asserts) have been removed, contributing to a cleaner and more up-to-date dependency tree. New dependencies like reth-node-ethstats and reth-trie-sparse-parallel have also been introduced.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the reth dependency to version 1.6.0. The changes correctly update the reth dependencies in Cargo.toml to use the v1.6.0 tag and adjust the code to the new version.

I've identified a couple of areas for improvement in Cargo.toml to enhance maintainability:

  • The alloy-* dependencies should be updated to versions compatible with reth 1.6.0.
  • There is a duplicate dependency declaration for reth-ethereum-primitives which should be removed.

Addressing these points will make the dependency specifications clearer and more robust.

@tac0turtle tac0turtle marked this pull request as ready for review July 23, 2025 10:01
@tac0turtle tac0turtle requested a review from a team as a code owner July 23, 2025 10:01
@tac0turtle tac0turtle requested review from alpe and julienrbrt July 23, 2025 10:02
@tac0turtle tac0turtle self-assigned this Jul 23, 2025
@tac0turtle tac0turtle enabled auto-merge (squash) July 23, 2025 12:24
@tac0turtle tac0turtle merged commit 15b1e4c into main Jul 23, 2025
14 checks passed
@tac0turtle tac0turtle deleted the marko/v1.6.0 branch July 23, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants