Conversation
|
Background infos on Manifest: https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#manifest-in |
ewels
left a comment
There was a problem hiding this comment.
Thanks for this! Well done for spotting that the pypi distribution is broken, sorry about that 🙈
One specific comment but my claude /review spotted the following:
MANIFEST.in alone may not be enough
MANIFEST.in controls what goes into the sdist (source tarball), but does not guarantee that template files end up in the wheel (the format pip actually installs from in most cases).
To ensure templates are included in installed packages, we also need to configure package data in pyproject.toml. For example, with setuptools:
[build-system]
requires = ["setuptools>=64"]
build-backend = "setuptools.build_meta"
[tool.setuptools.package-data]
nf_docs = ["templates/*"]Note: pyproject.toml currently has no [build-system] section at all, so this should also be added.
Missing trailing newline
The file is missing a newline at the end. Most editors and linters expect a trailing newline — without one, tools like git diff flag it with \ No newline at end of file.
Co-authored-by: Phil Ewels <phil.ewels@seqera.io>
ewels
left a comment
There was a problem hiding this comment.
Great stuff, thank you!
The CI failure is unrelated, I'll handle that in a separate PR before release. Thanks!
No description provided.