Filter tombstoned rows in ListCodeOwnerIdentities - #40
Merged
Conversation
The query's three branches (review requests, reviews, comments) read all historical rows for a repository: tombstoned identities leaked into the reviewer-candidate set, and without the tombstoned_at IS NULL predicate none of the branches could use the live-row partial indexes, so candidate listing scanned accumulated history. All three branches now filter live rows and match the partial-index predicates exactly -- verified by a planner test that seeds 5,000 tombstoned rows per table and asserts index-only scans on the *_live_pr_idx indexes with only live candidates returned. A tombstoned-then-re-requested identity appears exactly once, and every candidate-set consumer (ownership resolution, the CODEOWNERS mirror path, drift) was audited against the semantic change. Fixes #35 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ewhauser
force-pushed
the
codeowner-identity-index
branch
from
August 5, 2026 01:36
a0b0787 to
1265ba4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35 — tombstoned identities no longer leak into reviewer candidates, and all three query branches now match the live-row partial-index predicates. A planner regression seeds 5,000 tombstoned rows per table and asserts index-only scans returning only live candidates; re-requested identities appear exactly once; every candidate-set consumer audited.
Built and adversarially reviewed by paired Codex sol-xhigh agents in a dedicated worktree (parallel batch #33–#38). Full gate green locally.
🤖 Generated with Claude Code