Accept historical stack summaries where position exceeds size - #42
Merged
Conversation
resolve_stack_membership retried permanently when GitHub returned a historical stack summary whose recorded position exceeds the stack's current size -- truthful data after members merged out from under a merged PR, rejected by validation, the same class as the unknown base SHA (issue #12) and handled to its standard. A position beyond the current size now means historical membership: accepted by validation universally (GitHub can send it for open PRs too), never a tuple match for dispatch suppression (fails open into the eager stack refresh), converged identically by drift and the loadgen oracle on both sides, and inert in every identity or dedupe comparison -- each site enumerated and tested. C-C2 recency still orders summaries regardless of position validity. End-to-end regressions run the real worker with the issue's exact JSON shape through both REST and GraphQL paths, completing at attempt 1, with schema-valid fakegithub payloads via the preview-extension validator. Fixes #33 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ewhauser
force-pushed
the
stack-position-history
branch
from
August 5, 2026 01:48
49717f3 to
6bc6493
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33 — the #12 class again: truthful historical GitHub data (position > current size after stack members merge away) poisoned
resolve_stack_membershipthrough retry exhaustion. Now accepted universally with documented historical-membership semantics: never suppresses the eager stack refresh, converges in drift and the loadgen oracle, inert in identity comparisons (every site enumerated), C-C2 recency unaffected. Real-worker regressions with the issue's exact JSON complete at attempt 1 via both REST and GraphQL.Built and adversarially reviewed by paired Codex sol-xhigh agents in a dedicated worktree (parallel batch #33–#38). Full gate green locally.
🤖 Generated with Claude Code