🐛 app: misc fixes#1135
Conversation
🦋 Changeset detectedLatest commit: 8453074 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements several bug fixes and UI improvements. It updates the ToastProvider to target the mobile platform natively, removes the redundant native: true option from individual toast calls, and refactors the NotificationToast component to derive its type from the toast's preset or haptic options. Additionally, it fixes the display of quoteless bridge amounts by rendering a placeholder when the amount is undefined, and skips card activation prompts when card details are already present. There are no review comments, so I have no further feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Warning Review limit reached
Next review available in: 2 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (31)
WalkthroughThis PR removes the ChangesToast configuration and rendering
Estimated code review effort: 2 (Simple) | ~15 minutes Sequence Diagram(s)sequenceDiagram
participant RootLayout
participant ToastProvider
participant SafeToastViewport
participant NotificationToast
RootLayout->>ToastProvider: render with native="mobile"
ToastProvider->>SafeToastViewport: mount viewport with top || "$s4"
ToastProvider->>NotificationToast: pass toast data (no native flag)
NotificationToast->>NotificationToast: derive type from burntOptions.preset/haptic
NotificationToast-->>SafeToastViewport: render styled toast on web/native
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1135 +/- ##
==========================================
+ Coverage 71.87% 72.60% +0.73%
==========================================
Files 248 249 +1
Lines 10120 10124 +4
Branches 3287 3293 +6
==========================================
+ Hits 7274 7351 +77
+ Misses 2568 2495 -73
Partials 278 278
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/card/Card.tsx (1)
171-174: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winExtract the repeated error-toast options.
The
{ duration: 1000, burntOptions: { haptic: "error", preset: "error" } }literal is duplicated 4 times in this file alone (Lines 171-174, 189-192, 208-211, 243-246, 256-259). As per coding guidelines, "extract and abstract only with reuse (two or more uses)" — this clearly qualifies.♻️ Proposed helper extraction
+function showErrorToast(toast: ReturnType<typeof useToastController>, message: string) { + toast.show(message, { duration: 1000, burntOptions: { haptic: "error", preset: "error" } }); +} + export default function Card() { ... - toast.show(t("An error occurred. Please try again later."), { - duration: 1000, - burntOptions: { haptic: "error", preset: "error" }, - }); + showErrorToast(toast, t("An error occurred. Please try again later."));Also applies to: 189-192, 208-211, 232-235, 243-246, 256-259
Source: Coding guidelines
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 92e4c714-a560-4024-9d9b-22e88926d38f
📒 Files selected for processing (31)
.changeset/calm-heron-waves.md.changeset/calm-otters-reveal.md.changeset/ripe-dancers-shop.mdsrc/app/_layout.tsxsrc/components/activity/details/DeclinedActivity.tsxsrc/components/activity/details/PurchaseDetails.tsxsrc/components/activity/details/TransactionDetails.tsxsrc/components/add-funds/AddCrypto.tsxsrc/components/add-funds/AddFunds.tsxsrc/components/add-funds/Bridge.tsxsrc/components/add-funds/Fees.tsxsrc/components/add-funds/Ramp.tsxsrc/components/add-funds/Status.tsxsrc/components/card/Card.tsxsrc/components/card/CardDetails.tsxsrc/components/getting-started/GettingStarted.tsxsrc/components/home/CardStatus.tsxsrc/components/home/GettingStarted.tsxsrc/components/home/Home.tsxsrc/components/home/VisaSignatureSheet.tsxsrc/components/home/card-upgrade/ActivateCard.tsxsrc/components/home/card-upgrade/UpgradeAccount.tsxsrc/components/home/card-upgrade/VerifyIdentity.tsxsrc/components/loans/Receiver.tsxsrc/components/pay/Pay.tsxsrc/components/pay/PaymentSheet.tsxsrc/components/pay/RolloverIntroSheet.tsxsrc/components/roll-debt/RollDebt.tsxsrc/components/shared/Toast.tsxsrc/components/shared/ToastViewport.tsxsrc/utils/useAuth.ts
💤 Files with no reviewable changes (18)
- src/components/activity/details/DeclinedActivity.tsx
- src/components/activity/details/PurchaseDetails.tsx
- src/components/loans/Receiver.tsx
- src/components/pay/Pay.tsx
- src/components/home/card-upgrade/VerifyIdentity.tsx
- src/components/pay/PaymentSheet.tsx
- src/components/add-funds/AddCrypto.tsx
- src/components/getting-started/GettingStarted.tsx
- src/components/home/VisaSignatureSheet.tsx
- src/components/home/GettingStarted.tsx
- src/components/activity/details/TransactionDetails.tsx
- src/components/pay/RolloverIntroSheet.tsx
- src/components/add-funds/AddFunds.tsx
- src/components/home/CardStatus.tsx
- src/components/card/CardDetails.tsx
- src/components/roll-debt/RollDebt.tsx
- src/components/home/card-upgrade/ActivateCard.tsx
- src/utils/useAuth.ts
2 participants
Summary by CodeRabbit