🐛 app: fix proposal block override time#980
Conversation
WalkthroughThis PR introduces a patch-level update for the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 96713f67-6504-4c0c-8400-7589b8ed726a
📒 Files selected for processing (2)
.changeset/wild-geckos-remain.mdsrc/utils/useSimulateProposal.ts
| blockOverrides: timestamp?.status === "success" ? { time: timestamp.result + 1n } : undefined, | ||
| calls: request |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Add a regression test for timestamp boundary behavior.
Given this is a precision timing fix, add a focused test for the equality boundary (timestamp + delay) so this doesn’t regress.
Also applies to: 184-187
There was a problem hiding this comment.
Code Review
This pull request updates the useSimulateProposal utility to increment the block override timestamp by 1n in two simulation scenarios. This adjustment ensures that the simulated block time is strictly greater than the current timestamp, preventing potential simulation errors. A changeset file has also been included to document this patch. I have no feedback to provide.
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Prevent Tests Dashboard |
Summary by CodeRabbit