🔖 release: mobile@1.2.5, server@0.2.90#981
Conversation
WalkthroughBumps top-level mobile package to 1.2.5 and Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: ff5de849-047b-42a9-97fc-76cc72ba413d
📒 Files selected for processing (3)
.changeset/wild-geckos-remain.mdCHANGELOG.mdpackage.json
💤 Files with no reviewable changes (1)
- .changeset/wild-geckos-remain.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #981 +/- ##
==========================================
+ Coverage 73.00% 73.49% +0.48%
==========================================
Files 229 229
Lines 8728 8874 +146
Branches 2850 2927 +77
==========================================
+ Hits 6372 6522 +150
- Misses 2114 2117 +3
+ Partials 242 235 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
87c8107 to
e0da86f
Compare
e0da86f to
7e13373
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
CHANGELOG.md (1)
5-26:⚠️ Potential issue | 🟡 Minorkeep the new release block fully lowercase in narrative text.
this section still contains uppercase narrative words (
Patch Changes,Thanks,Updated dependencies) in changed lines.proposed fix
-### Patch Changes +### patch changes ... -- [`#985`](https://github.com/exactly/exa/pull/985) [`3e50726`](https://github.com/exactly/exa/commit/3e507266d8bd8137fd3a3a1450459825f5ce6533) Thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 💄 restructure swap state screen layouts +- [`#985`](https://github.com/exactly/exa/pull/985) [`3e50726`](https://github.com/exactly/exa/commit/3e507266d8bd8137fd3a3a1450459825f5ce6533) thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 💄 restructure swap state screen layouts ... -- Updated dependencies [[`d30e604`](https://github.com/exactly/exa/commit/d30e604affbc1938e754ca4144a059cf22a71b45)]: +- updated dependencies [[`d30e604`](https://github.com/exactly/exa/commit/d30e604affbc1938e754ca4144a059cf22a71b45)]:Based on learnings "Applies to **/.md : all internal documentation and commit messages must be lowercase" and "Applies to **/.md : all narrative text (headings, paragraphs, list items, proper nouns, brand names) in internal documentation must be lowercase. there are no exceptions".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: e947a946-bcf4-476d-ab1f-ae79798abb3f
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
.changeset/wild-geckos-remain.mdCHANGELOG.mdpackage.jsonserver/CHANGELOG.mdserver/package.json
💤 Files with no reviewable changes (1)
- .changeset/wild-geckos-remain.md
e277e20 to
f0a6eb8
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
CHANGELOG.md (1)
3-31:⚠️ Potential issue | 🟡 MinorFix changelog casing in the new 1.2.5 entry.
In the new
## 1.2.5section, these narrative words are capitalized:
### Patch Changes(Line 5~)Thanks ...across the bullet list (Lines 7~ through 27~)Updated dependencies ...(Line 29~)Per the markdown casing rule for internal documentation, they should be lowercase.
🛠️ Proposed fix
## 1.2.5 - -### Patch Changes +### patch changes @@ -- [`#985`](https://github.com/exactly/exa/pull/985) [`3e50726`](https://github.com/exactly/exa/commit/3e507266d8bd8137fd3a3a1450459825f5ce6533) Thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 💄 restructure swap state screen layouts +- [`#985`](https://github.com/exactly/exa/pull/985) [`3e50726`](https://github.com/exactly/exa/commit/3e507266d8bd8137fd3a3a1450459825f5ce6533) thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 💄 restructure swap state screen layouts @@ -- [`#973`](https://github.com/exactly/exa/pull/973) [`acef232`](https://github.com/exactly/exa/commit/acef232279552bb9016708f666c602ac1c5b829b) Thanks [`@franm91`](https://github.com/franm91)! - ✨ support bridge kyc link +- [`#973`](https://github.com/exactly/exa/pull/973) [`acef232`](https://github.com/exactly/exa/commit/acef232279552bb9016708f666c602ac1c5b829b) thanks [`@franm91`](https://github.com/franm91)! - ✨ support bridge kyc link @@ -- [`#985`](https://github.com/exactly/exa/pull/985) [`69588da`](https://github.com/exactly/exa/commit/69588dac4b3533d4b541c24e07bf360404799d93) Thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 🐛 fix usd display for dust token balances +- [`#985`](https://github.com/exactly/exa/pull/985) [`69588da`](https://github.com/exactly/exa/commit/69588dac4b3533d4b541c24e07bf360404799d93) thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 🐛 fix usd display for dust token balances @@ -- [`#986`](https://github.com/exactly/exa/pull/986) [`14d4e28`](https://github.com/exactly/exa/commit/14d4e28f96c551a79c996d5d888a2796e554108d) Thanks [`@franm91`](https://github.com/franm91)! - ✨ add stellar memo +- [`#986`](https://github.com/exactly/exa/pull/986) [`14d4e28`](https://github.com/exactly/exa/commit/14d4e28f96c551a79c996d5d888a2796e554108d) thanks [`@franm91`](https://github.com/franm91)! - ✨ add stellar memo @@ -- [`#985`](https://github.com/exactly/exa/pull/985) [`7a445dc`](https://github.com/exactly/exa/commit/7a445dc61a79e8b221ed411dcb8e31c12aa0dabe) Thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 🐛 disable retries in custom transport +- [`#985`](https://github.com/exactly/exa/pull/985) [`7a445dc`](https://github.com/exactly/exa/commit/7a445dc61a79e8b221ed411dcb8e31c12aa0dabe) thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 🐛 disable retries in custom transport @@ -- [`#985`](https://github.com/exactly/exa/pull/985) [`1be0bd8`](https://github.com/exactly/exa/commit/1be0bd87999ba64b543dcba6e05ec437778c1330) Thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 💄 align close buttons to start +- [`#985`](https://github.com/exactly/exa/pull/985) [`1be0bd8`](https://github.com/exactly/exa/commit/1be0bd87999ba64b543dcba6e05ec437778c1330) thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 💄 align close buttons to start @@ -- [`#985`](https://github.com/exactly/exa/pull/985) [`d89abcc`](https://github.com/exactly/exa/commit/d89abcc0a1e2dd171c2a96e82cae26d158443bbd) Thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 💄 refine portfolio tap feedback +- [`#985`](https://github.com/exactly/exa/pull/985) [`d89abcc`](https://github.com/exactly/exa/commit/d89abcc0a1e2dd171c2a96e82cae26d158443bbd) thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 💄 refine portfolio tap feedback @@ -- [`#985`](https://github.com/exactly/exa/pull/985) [`8aa9f1b`](https://github.com/exactly/exa/commit/8aa9f1b0a4b2f931fddbcf98c620855ef125112e) Thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 💄 improve defi sheets layout +- [`#985`](https://github.com/exactly/exa/pull/985) [`8aa9f1b`](https://github.com/exactly/exa/commit/8aa9f1b0a4b2f931fddbcf98c620855ef125112e) thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 💄 improve defi sheets layout @@ -- [`#985`](https://github.com/exactly/exa/pull/985) [`7e59d69`](https://github.com/exactly/exa/commit/7e59d693a6cfff1574895739e3e355545a4debd8) Thanks [`@dieguezguille`](https://github.com/dieguezguille)! - ♻️ use sets for query client exclusions +- [`#985`](https://github.com/exactly/exa/pull/985) [`7e59d69`](https://github.com/exactly/exa/commit/7e59d693a6cfff1574895739e3e355545a4debd8) thanks [`@dieguezguille`](https://github.com/dieguezguille)! - ♻️ use sets for query client exclusions @@ -- [`#980`](https://github.com/exactly/exa/pull/980) [`45fcb30`](https://github.com/exactly/exa/commit/45fcb3031a14c6d55c65b47acb4e634c2ac36b40) Thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 🐛 fix proposal block override time +- [`#980`](https://github.com/exactly/exa/pull/980) [`45fcb30`](https://github.com/exactly/exa/commit/45fcb3031a14c6d55c65b47acb4e634c2ac36b40) thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 🐛 fix proposal block override time @@ -- [`#985`](https://github.com/exactly/exa/pull/985) [`5e3d3fc`](https://github.com/exactly/exa/commit/5e3d3fcc7f8d5a941ac878bc74041835fa816e01) Thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 🐛 stabilize receiver input controlled state +- [`#985`](https://github.com/exactly/exa/pull/985) [`5e3d3fc`](https://github.com/exactly/exa/commit/5e3d3fcc7f8d5a941ac878bc74041835fa816e01) thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 🐛 stabilize receiver input controlled state @@ -- Updated dependencies [[`7093014`](https://github.com/exactly/exa/commit/70930149004f567dc5366d183c5cadc5d5cbcc63), [`d30e604`](https://github.com/exactly/exa/commit/d30e604affbc1938e754ca4144a059cf22a71b45)]: +- updated dependencies [[`7093014`](https://github.com/exactly/exa/commit/70930149004f567dc5366d183c5cadc5d5cbcc63), [`d30e604`](https://github.com/exactly/exa/commit/d30e604affbc1938e754ca4144a059cf22a71b45)]:
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: cad771e5-4d32-4306-af67-a953621a26cb
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (14)
.changeset/bright-foxes-swim.md.changeset/bright-owls-glow.md.changeset/brisk-otters-sing.md.changeset/fuzzy-adults-tease.md.changeset/open-coats-battle.md.changeset/soft-ferrets-tap.md.changeset/strong-kings-pay.md.changeset/wicked-buses-go.md.changeset/wild-geckos-remain.md.changeset/witty-emus-divide.mdCHANGELOG.mdpackage.jsonserver/CHANGELOG.mdserver/package.json
💤 Files with no reviewable changes (10)
- .changeset/brisk-otters-sing.md
- .changeset/soft-ferrets-tap.md
- .changeset/strong-kings-pay.md
- .changeset/fuzzy-adults-tease.md
- .changeset/wild-geckos-remain.md
- .changeset/bright-foxes-swim.md
- .changeset/bright-owls-glow.md
- .changeset/witty-emus-divide.md
- .changeset/open-coats-battle.md
- .changeset/wicked-buses-go.md
f0a6eb8 to
33a1a2b
Compare
33a1a2b to
dfbd4de
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (2)
server/CHANGELOG.md (1)
5-11:⚠️ Potential issue | 🟡 Minoruse lowercase narrative text in the new changelog entry.
the new section still uses uppercase narrative words (
Patch Changes,Thanks), which violates repository markdown casing rules.proposed fix
-### Patch Changes +### patch changes @@ -- [`#951`](https://github.com/exactly/exa/pull/951) [`7093014`](https://github.com/exactly/exa/commit/70930149004f567dc5366d183c5cadc5d5cbcc63) Thanks [`@mainqueg`](https://github.com/mainqueg)! - ✨ add evm network support for bridge onramp +- [`#951`](https://github.com/exactly/exa/pull/951) [`7093014`](https://github.com/exactly/exa/commit/70930149004f567dc5366d183c5cadc5d5cbcc63) thanks [`@mainqueg`](https://github.com/mainqueg)! - ✨ add evm network support for bridge onramp @@ -- [`#950`](https://github.com/exactly/exa/pull/950) [`d30e604`](https://github.com/exactly/exa/commit/d30e604affbc1938e754ca4144a059cf22a71b45) Thanks [`@mainqueg`](https://github.com/mainqueg)! - ✨ add kyc link allowlist for bridge onboarding +- [`#950`](https://github.com/exactly/exa/pull/950) [`d30e604`](https://github.com/exactly/exa/commit/d30e604affbc1938e754ca4144a059cf22a71b45) thanks [`@mainqueg`](https://github.com/mainqueg)! - ✨ add kyc link allowlist for bridge onboarding @@ -- [`#893`](https://github.com/exactly/exa/pull/893) [`d0a9c1a`](https://github.com/exactly/exa/commit/d0a9c1ac54338e487a9cf4f14b9775c16ccbf5cf) Thanks [`@nfmelendez`](https://github.com/nfmelendez)! - ✨ support multiple cards in statement +- [`#893`](https://github.com/exactly/exa/pull/893) [`d0a9c1a`](https://github.com/exactly/exa/commit/d0a9c1ac54338e487a9cf4f14b9775c16ccbf5cf) thanks [`@nfmelendez`](https://github.com/nfmelendez)! - ✨ support multiple cards in statementAs per coding guidelines "
**/*.md: all internal documentation and commit messages must be lowercase" and "all narrative text (headings, paragraphs, list items, proper nouns, brand names) in internal documentation must be lowercase. there are no exceptions".CHANGELOG.md (1)
5-32:⚠️ Potential issue | 🟡 Minorconvert new release narrative text to lowercase.
the new
1.2.5entry includes uppercase narrative text (Patch Changes,Thanks,Updated dependencies), which breaks markdown casing policy.proposed fix pattern
-### Patch Changes +### patch changes @@ -- [`#985`](https://github.com/exactly/exa/pull/985) [`3e50726`](https://github.com/exactly/exa/commit/3e507266d8bd8137fd3a3a1450459825f5ce6533) Thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 💄 restructure swap state screen layouts +- [`#985`](https://github.com/exactly/exa/pull/985) [`3e50726`](https://github.com/exactly/exa/commit/3e507266d8bd8137fd3a3a1450459825f5ce6533) thanks [`@dieguezguille`](https://github.com/dieguezguille)! - 💄 restructure swap state screen layouts @@ -- Updated dependencies [[`7093014`](https://github.com/exactly/exa/commit/70930149004f567dc5366d183c5cadc5d5cbcc63), [`d30e604`](https://github.com/exactly/exa/commit/d30e604affbc1938e754ca4144a059cf22a71b45), [`d0a9c1a`](https://github.com/exactly/exa/commit/d0a9c1ac54338e487a9cf4f14b9775c16ccbf5cf)]: +- updated dependencies [[`7093014`](https://github.com/exactly/exa/commit/70930149004f567dc5366d183c5cadc5d5cbcc63), [`d30e604`](https://github.com/exactly/exa/commit/d30e604affbc1938e754ca4144a059cf22a71b45), [`d0a9c1a`](https://github.com/exactly/exa/commit/d0a9c1ac54338e487a9cf4f14b9775c16ccbf5cf)]:As per coding guidelines "
**/*.md: all internal documentation and commit messages must be lowercase" and "all narrative text (headings, paragraphs, list items, proper nouns, brand names) in internal documentation must be lowercase. there are no exceptions".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 36d9b8b5-2f70-4498-9162-6d21f970569f
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (17)
.changeset/bright-evm-arrive.md.changeset/bright-foxes-swim.md.changeset/bright-masks-attend.md.changeset/bright-owls-glow.md.changeset/brisk-otters-sing.md.changeset/fluffy-cameras-rush.md.changeset/fuzzy-adults-tease.md.changeset/open-coats-battle.md.changeset/soft-ferrets-tap.md.changeset/strong-kings-pay.md.changeset/wicked-buses-go.md.changeset/wild-geckos-remain.md.changeset/witty-emus-divide.mdCHANGELOG.mdpackage.jsonserver/CHANGELOG.mdserver/package.json
💤 Files with no reviewable changes (13)
- .changeset/fluffy-cameras-rush.md
- .changeset/bright-owls-glow.md
- .changeset/bright-evm-arrive.md
- .changeset/wild-geckos-remain.md
- .changeset/wicked-buses-go.md
- .changeset/strong-kings-pay.md
- .changeset/brisk-otters-sing.md
- .changeset/open-coats-battle.md
- .changeset/fuzzy-adults-tease.md
- .changeset/bright-foxes-swim.md
- .changeset/soft-ferrets-tap.md
- .changeset/bright-masks-attend.md
- .changeset/witty-emus-divide.md
Releases
@exactly/mobile@1.2.5
Patch Changes
#985
3e50726Thanks @dieguezguille! - 💄 restructure swap state screen layouts#973
acef232Thanks @franm91! - ✨ support bridge kyc link#985
69588daThanks @dieguezguille! - 🐛 fix usd display for dust token balances#986
14d4e28Thanks @franm91! - ✨ add stellar memo#985
7a445dcThanks @dieguezguille! - 🐛 disable retries in custom transport#985
1be0bd8Thanks @dieguezguille! - 💄 align close buttons to start#985
d89abccThanks @dieguezguille! - 💄 refine portfolio tap feedback#985
8aa9f1bThanks @dieguezguille! - 💄 improve defi sheets layout#987
8d4a628Thanks @franm91! - ✨ add base ramp#985
7e59d69Thanks @dieguezguille! - ♻️ use sets for query client exclusions#980
45fcb30Thanks @dieguezguille! - 🐛 fix proposal block override time#985
5e3d3fcThanks @dieguezguille! - 🐛 stabilize receiver input controlled stateUpdated dependencies [
7093014,d30e604,d0a9c1a]:@exactly/server@0.2.90
Patch Changes
#951
7093014Thanks @mainqueg! - ✨ add evm network support for bridge onramp#950
d30e604Thanks @mainqueg! - ✨ add kyc link allowlist for bridge onboarding#893
d0a9c1aThanks @nfmelendez! - ✨ support multiple cards in statementSummary by CodeRabbit
New Features
Bug Fixes
Chores