Skip to content

✨ app: add base ramp#987

Merged
cruzdanilo merged 1 commit intomainfrom
ramp-base
Apr 29, 2026
Merged

✨ app: add base ramp#987
cruzdanilo merged 1 commit intomainfrom
ramp-base

Conversation

@franm91
Copy link
Copy Markdown
Member

@franm91 franm91 commented Apr 29, 2026


Open in Devin Review

Summary by CodeRabbit

New Features

  • Added support for Base network in the funds onboarding interface, enabling users to select and onboard using the Base network with proper visual identification and branding.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 29, 2026

🦋 Changeset detected

Latest commit: 8d4a628

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 86659e3c-2090-4c9e-9663-6162ca3eab59

📥 Commits

Reviewing files that changed from the base of the PR and between d0a9c1a and 8d4a628.

⛔ Files ignored due to path filters (1)
  • src/assets/images/base.svg is excluded by !**/*.svg
📒 Files selected for processing (3)
  • .changeset/three-ways-throw.md
  • src/components/add-funds/Onboard.tsx
  • src/utils/networkLogos.ts

Walkthrough

A changeset entry documents a patch release for the mobile app. The BASE network is added to the add-funds feature by importing its icon, mapping it in the onboarding UI component, and providing a logo URL in the network logos utility.

Changes

Cohort / File(s) Summary
Changeset metadata
.changeset/three-ways-throw.md
Patch release entry for @exactly/mobile documenting the base ramp feature addition.
Network support implementation
src/components/add-funds/Onboard.tsx, src/utils/networkLogos.ts
BASE network added to onboarding UI's network-to-icon mapping and to the networkLogos record with its corresponding logo URL.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • dieguezguille
  • cruzdanilo
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding Base network support (Ramp integration) to the app, which is reflected across all three modified files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ramp-base

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the Base network by introducing its logo asset, updating the onboarding component to include it in the network list, and adding its remote logo URL. A review comment identified that the new SVG's viewBox is inconsistent with the application's coordinate system, which would cause the logo to appear off-center.

Comment thread src/assets/images/base.svg
@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.00%. Comparing base (d0a9c1a) to head (8d4a628).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #987      +/-   ##
==========================================
+ Coverage   72.22%   73.00%   +0.78%     
==========================================
  Files         229      229              
  Lines        8392     8728     +336     
  Branches     2693     2850     +157     
==========================================
+ Hits         6061     6372     +311     
- Misses       2100     2114      +14     
- Partials      231      242      +11     
Flag Coverage Δ
e2e 71.79% <ø> (+19.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cruzdanilo cruzdanilo merged commit 8d4a628 into main Apr 29, 2026
12 of 13 checks passed
@cruzdanilo cruzdanilo deleted the ramp-base branch April 29, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants