[WIP] Address feedback from review on PR #21 for 070 changes#24
Merged
[WIP] Address feedback from review on PR #21 for 070 changes#24
Conversation
Merged
Co-authored-by: alvagante <283804+alvagante@users.noreply.github.com>
Copilot stopped work on behalf of
alvagante due to an error
February 23, 2026 21:45
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses feedback from PR #21 by implementing support for debug-level logging in PuppetRunHistoryService and downgrading two verbose informational log messages to debug level. The changes improve logging granularity by making detailed operational logs (date ranges and conversion counts) only appear when debug logging is enabled, reducing noise at the default info level.
Changes:
- Extended the private
log()helper method to support "debug" log level - Downgraded two verbose log messages from info to debug level (date range and history conversion count)
| * @param level - Log level (default: info) | ||
| */ | ||
| private log(message: string, level: "info" | "warn" | "error" = "info"): void { | ||
| private log(message: string, level: "debug" | "info" | "warn" | "error" = "info"): void { |
There was a problem hiding this comment.
The order of log levels in the type union should match the established hierarchy pattern used in LoggerService (error > warn > info > debug). Consider reordering to: level: "error" | "warn" | "info" | "debug" = "info" for consistency with the codebase convention.
Suggested change
| private log(message: string, level: "debug" | "info" | "warn" | "error" = "info"): void { | |
| private log(message: string, level: "error" | "warn" | "info" | "debug" = "info"): void { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log()helper inPuppetRunHistoryServiceto support"debug"level viaLoggerService.debug()Date range: ...log (line 131) frominfotodebugConverted to ... days of historylog (line 144) frominfotodebug💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.