This repository was archived by the owner on Jun 11, 2019. It is now read-only.
Added a new parameter for mysql_db_create_options to grant.pp #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, don't want to be picky, but a space is added to the existing file and therefore the mysql exec would be executed the same. The query anyway should be safe to be re-executed. Can you place an if statement in the template taking care to not introduce any space? :-) |
|
sorry ... my fault - I've seen one test becomes red. |
|
Fixed and added an additional test for the new parameter. |
alvagante
added a commit
that referenced
this pull request
May 30, 2013
Added a new parameter for mysql_db_create_options to grant.pp
|
Thanks lot :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added a new parameter for mysql_db_create_options (I needed 'character set utf8' on my server). The default is set to '' so the the defined type should remain backward compatible.
Best regards,
jerger