Skip to content
This repository was archived by the owner on Nov 11, 2021. It is now read-only.

(#250) Use _cidr variable to generate routing config on EL#251

Merged
alvagante merged 1 commit intoexample42:masterfrom
desyops:routing_rhel
Sep 27, 2018
Merged

(#250) Use _cidr variable to generate routing config on EL#251
alvagante merged 1 commit intoexample42:masterfrom
desyops:routing_rhel

Conversation

@stdietrich
Copy link
Copy Markdown
Contributor

@stdietrich stdietrich commented Sep 20, 2018

With NetworkManager >=1.10, it is no longer valid to specify a routing
with a netmask, e.g. "192.168.1.0/255.255.255.0".
NetworkManager now requires the CIDR notation, e.g. "192.168.1.0/24".

Before submitting your PR

  1. Open an issue and refer to its number in your PR title
  2. If it's a bug and you have the solution, go on with the PR!
  3. If it's an enhancement, please wait for our feedback before starting to work on it
  4. Please run puppet-lint on your code and ensure it's compliant

After submitting your PR

  1. Verify Travis checks and eventually fix the errors
  2. Feel free to ping us if we don't reply promptly

@stdietrich
(example42#250) Use _cidr variable to generate routing config on EL
acce213 
With NetworkManager >=1.10, it is no longer valid to specify a routing
with a netmask, e.g. "192.168.1.0/255.255.255.0".
NetworkManager now requires the CIDR notation, e.g. "192.168.1.0/24".
@alvagante alvagante merged commit 7136b4e into example42:master Sep 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stdietrich @alvagante