fix: OpenAPI schema incorrectly marks properties with default initializers as required#2096
Draft
Copilot wants to merge 3 commits intofeature/mapperlyfrom
Draft
fix: OpenAPI schema incorrectly marks properties with default initializers as required#2096Copilot wants to merge 3 commits intofeature/mapperlyfrom
Copilot wants to merge 3 commits intofeature/mapperlyfrom
Conversation
|
|
…nAPI schema Properties with default initializers (like ExtraData = new()) are now correctly treated as optional unless they have the explicit 'required' modifier. Co-authored-by: niemyjski <1020579+niemyjski@users.noreply.github.com>
Co-authored-by: niemyjski <1020579+niemyjski@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Find root cause analysis and apply fix
fix: OpenAPI schema incorrectly marks properties with default initializers as required
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RequiredPropertySchemaTransformerwas marking all non-nullable reference types as required in OpenAPI schemas, including properties with default initializers. This causedOAuthAccount.ExtraDatato appear as required when it shouldn't be:Solution
Check for C# 11+
RequiredMemberAttributeinstead of relying on nullability context:Reference types are now only marked as required if they have the explicit
requiredmodifier. Non-nullable value types remain required as before.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.