Polish detail sheet and stack card UI#2263
Merged
Merged
Conversation
- Create shared DetailSheet component for event/stack sheets - Refactor event-detail-sheet and stack-detail-sheet to use DetailSheet - Refactor project stack detail page to use shared StackDetails component - Remove wrapper divs from full page routes for consistent padding - Add subtle blur overlay and slide animation to sheet - Improve stack no-events state with STACK header - Restyle stack card stat boxes to match saved view dashboard style - Fix text descender clipping in stat card values
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
DetailSheetcomponent — extracted common sheet chrome (overlay, close button, external link, padding) into a reusable component used by bothevent-detail-sheetandstack-detail-sheetproject/[projectId]/stacks/[stackId]page now uses the sharedStackDetailscomponent instead of duplicating its logic<div>from full page routes so content matches the sheet's paddingbackdrop-blur-[0.5px]), slide-in animation, proper z-ordering below navbarEventsStatsDashboardcard pattern (Card.Root with header/content layout, muted background, 1px border)leading-nonefrom stat values that was causing descender clipping on text like "3 days ago"Why
UI consistency pass — the detail sheets and stack cards now share code and have a polished, consistent look matching the saved view dashboard stats.