Polish event detail sheet: tabs, stack traces, syntax colors#2266
Merged
Conversation
- Fix event navigation flash by using keepPreviousData in TanStack Query - Style stack trace pre elements with bg-muted/50, rounded-xl, border - Fix Code component: use cn() for proper class merging, collapse template to avoid whitespace in pre elements, restore bg-muted default - Change copy stack trace button to outline variant matching other icons
- Restyle event tabs to match settings nav (bg-muted, gap, rounded-lg) - Add active tab dark mode styling (bg-background, shadow-xs) - Update stack trace container (bg-muted/50, rounded-xl, border) - Fix code component whitespace and use cn() for class merging - Change syntax colors: purple-400 -> purple-300, emerald-400 -> green-300 - Restyle copy buttons to icon-sm outline variant - Use keepPreviousData to prevent flash on event navigation
ejsmith
force-pushed
the
ui/detail-sheet-polish-2
branch
from
c60b21f to
c88232f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Visual polish for the event detail sheet to improve consistency and readability.
Tabs
bg-muted,rounded-lg,gap-1,p-1)bg-background,shadow-xs,border-transparent)Stack traces
bg-muted/50,rounded-xl, subtle bordercn()for proper Tailwind class merging<pre>bg-transparentinstead ofbg-inherit)Syntax highlighting
purple-400→purple-300,emerald-400→green-300Copy buttons
size="icon-sm" variant="outline"for consistencyEvent navigation
keepPreviousDatato prevent content flash when navigating between events