Skip to content

fix: switch to kernel_manager_class#725

Merged
bsipocz merged 1 commit into
executablebooks:mainfrom
flying-sheep:kmc
Jul 23, 2026
Merged

fix: switch to kernel_manager_class#725
bsipocz merged 1 commit into
executablebooks:mainfrom
flying-sheep:kmc

Conversation

@flying-sheep

@flying-sheep flying-sheep commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Sorry for that. Trying to use the new feature, I realized that jupyter_cache doesn’t have a way to close the kernel client and neither does nbclient’s execute, seems like they don’t really test that API.

This variant works, since it goes down the owns_kc path and therefore shuts down everything nicely.

This time I actually checked if it works as expected: flying-sheep/sphinx-exec-jupyter#33

@bsipocz

bsipocz commented Jul 20, 2026

Copy link
Copy Markdown
Member

Thanks @flying-sheep for the follow-up. I'm pretty sure the rtd failure is unrelated but I'll have to have a closer code when I'm back at the keyboard before merging this.

@flying-sheep

Copy link
Copy Markdown
Contributor Author

Thank you! Again, very sorry, I didn’t consider this.

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTD failure is unrelated, so let's have this in. Thanks @flying-sheep!

@bsipocz
bsipocz merged commit 1affb26 into executablebooks:main Jul 23, 2026
12 of 13 checks passed
@flying-sheep
flying-sheep deleted the kmc branch July 23, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants