SED-4409 Keyword calls with no agent response have no measurements

[david-stephan]

No description provided.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[jeromecomte]

Requiring some clarification.
If possible we should also cover with JUnit

[jeromecomte]

Not sure about this default. If we cannot resolve the KW name, this means, that the function couldn't be found. Do we really create this measure in this case? this default works only if hte nodeName is equals to the KW name, which is also not a guaranty. Instead, we could use a specific name: "Unresoved" or something specific. Not sure

[david-stephan]

I'm not really sure either. But if we really want to not miss any keyword call errors in the measurements / response time time-series, then I guess we should also create a measure in this case. As for the fall back name then I would propose to use the node name (as it gives a hint) + "_Unresolved". Example for a KW added from the component list and a CallKeyword by attributes:

[jeromecomte]

Agree with your proposition.

…

On Fri, Nov 28, 2025, 14:31 David Stephan ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In step-plans/step-plans-base-artefacts/src/main/java/step/artefacts/handlers/CallFunctionHandler.java <#561 (comment)>: > + + /** + * A Call function shall always have a measure of type "keyword", if the output measure is empty (mostly happen in case the agent call was not completed due to interruption), we create one directly here + * Note don't use Map.of(), List.of() as these could be enriched with more content later + * The status is left null to keep the default logic: node status is used when converting Measure to Measurement by the MeasurementPlugin + * @param node the node for which we ensure a keyword measure exists + * @param measureName the name of the measure to be created, fallback to node name if null + * @param endTime the measure endtime, fallback to current time if null + * @param startTime the startTime of the measure + */ + private static void createKeywordMeasureIfAbsent(CallFunctionReportNode node, String measureName, Long endTime, long startTime) { + if (node.getMeasures() == null || node.getMeasures().isEmpty()) { + Map<String, Object> data = new HashMap<>(); + data.put(MeasureTypes.ATTRIBUTE_TYPE, MeasureTypes.TYPE_KEYWORD); + List<Measure> measures = Objects.requireNonNullElse(node.getMeasures(), new ArrayList<>()); + measureName = Objects.requireNonNullElse(measureName, node.getName()); I'm not really sure either. But if we really want to not miss any keyword call errors in the measurements / response time time-series, then I guess we should also create a measure in this case. As for the fall back name then I would propose to use the node name (as it gives a hint) + "_Unresolved". Example for a KW added from the component list and a CallKeyword by attributes: image.png (view on web) <https://github.com/user-attachments/assets/1cef0d42-7f57-4cc8-9b4c-1db8e51b2b87> — Reply to this email directly, view it on GitHub <#561 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEG24ZGVSCYFIKY575C23PD37BFDJAVCNFSM6AAAAACNOO7P2WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKMJZGAYTSNJUGY> . You are receiving this because your review was requested.Message ID: ***@***.***>