Skip to content

Conversation

@Su24nn3
Copy link
Contributor

@Su24nn3 Su24nn3 commented Sep 7, 2023

Added example about where to find the line to move past the next test.

Added example about where to find the line to move past the next test.
@github-actions github-actions bot closed this Sep 7, 2023
@vaeng vaeng reopened this Sep 7, 2023
@vaeng
Copy link
Contributor

vaeng commented Sep 7, 2023

Hello @apprentiLAB-Suzanne,

thanks for your PR. It is a good thing to show an actual file. The bob exercise might be unknown, so I would show it and not make the person search for the source code of the bob test. Probably something like:

To include the next test you have to move the line with if defined(EXERCISM_RUN_ALL_TESTS) past the desired test.
See the example below from the Bob exercise:

-#if defined(EXERCISM_RUN_ALL_TESTS)
TEST_CASE("shouting")
{
    REQUIRE("Whoa, chill out!" == bob::hey("WATCH OUT!"));
}
+#if defined(EXERCISM_RUN_ALL_TESTS)

@Su24nn3
Copy link
Contributor Author

Su24nn3 commented Sep 12, 2023

Hi @vaeng,
thanks for the suggestion, I updated the PR !
I kept "next test", instead of "desired test". I find that it might be simpler for beginners, if you prefer otherwise I can change it 🙂
Cheers

@exercism exercism deleted a comment from github-actions bot Sep 13, 2023
Copy link
Contributor

@vaeng vaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vaeng vaeng merged commit 6812e75 into exercism:main Sep 13, 2023
@Su24nn3 Su24nn3 deleted the patch-2 branch September 13, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants