Implement High Scores exercise by CodeMartian · Pull Request #1767 · exercism/java

CodeMartian · 2019-10-04T20:02:01Z

Reviewer Resources:

lemoncurry

Hi @JeffMartian , we get the following error messages for your PR that need to be resolved:
-> An implementation for 'gradle' was found, but config.json does not reference this exercise.
-> The implementation for 'gradle' is missing a README.
-> The implementation for 'gradle' is missing an example solution.
-> The implementation for 'gradle' is missing a test suite.

If you need any help or have any questions on how to implement an exercise for the Java track, please let us know. In CONTRIBUTING.md, we explain what steps are necessary to add a new exercise to the Java track.

CodeMartian · 2019-10-16T16:02:27Z

Hi @lemoncurry! Yeah, I'm not sure why I'm getting those errors in the build.. I checked the config.json and ensured I have a high-scores entry in there. I also have a README, example solution, and a test suite for the exercise. Would you happen to have any advice or insight to these errors?

bmuskalla · 2019-10-16T19:46:30Z

@JeffMartian I'm not sure if this was on purpose but you seem to have added gradle binaries and a gradle wrapper script in the exercises/ folder

…e supplied array of high scores

…lection of high scores

…n list of high scores

…tion

jmrunkle · 2020-04-14T17:28:46Z

@lemoncurry - are you still available to do this review or should one of the other maintainers take over?

jmrunkle · 2020-04-22T14:17:46Z

@lemoncurry - are you still available to do this review or should one of the other maintainers take over?

I'm taking that as a no. I'll takeover this one.

config.json

jmrunkle · 2020-04-22T14:20:46Z

exercises/high-scores/.meta/src/reference/java/HighScores.java

+import static java.util.Arrays.copyOf;
+import static java.util.Arrays.sort;
+
+class HighScores {


NOTE: comments on this reference solution are just suggestions.

exercises/high-scores/.meta/src/reference/java/HighScores.java

jmrunkle · 2020-04-22T14:24:03Z

exercises/high-scores/README.md

+```sh
+gradle test
+```
+
+- Use gradlew.bat if you're on Windows


Regenerate this since we got rid of the advice to use gradlew.bat.

jmrunkle · 2020-04-22T14:25:57Z

exercises/high-scores/.meta/src/reference/java/HighScores.java

+        return personalBest.orElse(0);
+    }
+
+    Integer[] personalTopThree() {


Suggested change

Integer[] personalTopThree() {

int[] personalTopThree() {

Everything else uses primitives - so why would we return a boxed array?

jmrunkle · 2020-04-22T14:27:12Z

exercises/high-scores/src/main/java/HighScores.java

@@ -0,0 +1,21 @@
+class HighScores {
+    public HighScores(int[] highScores) {


Personally, I think this should take a List since a player's high scores are likely to change over time. Arrays are better if the collection has a fixed size.

jmrunkle · 2020-04-22T14:29:46Z

config.json

+      "slug": "high-scores",
+      "uuid": "574d6323-5ff5-4019-9ebe-0067daafba13",
+      "core": true,
+      "unlocked_by": null,


Should be unlocked by something. I think two-fer is a good one to unlock this.

jmrunkle · 2020-04-22T14:30:50Z

config.json

+      "uuid": "574d6323-5ff5-4019-9ebe-0067daafba13",
+      "core": true,
+      "unlocked_by": null,
+      "difficulty": 1,


This is probably difficulty 2 since it deals with storing member variables and then answering questions about those member variables.

NOTE: you should also move this down in the file into the difficulty 2 section (after the core exercise).

jmrunkle · 2020-04-22T14:33:05Z

exercises/high-scores/src/test/java/HighScoresTest.java

+    @Ignore("Remove to run test")
+    public void shouldReturnTopThreePersonalBestFromListOfScores() {
+        HighScores highScores = new HighScores(new int[] { 10, 30, 90, 30, 100, 20, 10, 0, 30, 40, 40, 70, 70 });
+        assertArrayEquals(new Integer[] { 100, 90, 70 }, highScores.personalTopThree());


You made these personalTopThree fit your reference solution (the one in .meta/), but not your implementation stub. The stub expects int[], but your reference solution returns Integer[]. To be honest, it really should be int[] since the rest of the class uses primitives.

jmrunkle · 2020-04-26T21:03:59Z

@JeffMartian - are you still working on this PR?

IA-JeffMartian · 2020-04-28T17:12:26Z

@jmrunkle Yes I am! I haven't had a chance to make the requested changes yet though. I'm hoping to be able to get through it by the end of this week.

Co-authored-by: Jason Runkle <jmrunkle@gmail.com>

jmrunkle · 2021-09-11T02:13:43Z

I am so sorry that I lost track of this PR - any chance you are willing to synchronize this with the current state of the files? Otherwise I'll probably close the PR in the next week (you can always open a new one later).

CodeMartian force-pushed the master branch from fe3aa3d to cbf05f4 Compare October 8, 2019 17:20

CodeMartian changed the title ~~WIP - Implement High Scores exercise~~ Implement High Scores exercise Oct 8, 2019

lemoncurry suggested changes Oct 16, 2019

View reviewed changes

CodeMartian added 11 commits October 16, 2019 14:55

Initial high-scores setup

98f8d7e

Create HighScoresTest class and barebones HighScores class

d120944

HighScores returns array of supplied high scores

e99c2ad

HighScores latest function now returns the last submitted score in th…

c2aa4a2

…e supplied array of high scores

HighScores personalBest returns the highest score in the supplied col…

ab5e5ec

…lection of high scores

HighScores personalTopThree returns the top 3 high scores from a give…

683bda0

…n list of high scores

HighScoresTest is fully passing when run against reference implementa…

dafcfe0

…tion

Set Ignore annotations on tests and minor cleanup

e0c847d

Updated README

b6e28f0

Updated config.json

2914b72

removed unnecessary gradle binaries and scripts from exercises folder

4da466d

CodeMartian force-pushed the master branch from d640493 to 4da466d Compare October 16, 2019 19:55

CodeMartian requested a review from lemoncurry October 17, 2019 15:04

jmrunkle requested review from jmrunkle and removed request for lemoncurry April 22, 2020 14:18

jmrunkle suggested changes Apr 22, 2020

View reviewed changes

CodeMartian and others added 3 commits July 13, 2020 17:37

Disable this as a core exercise

18823c8

Co-authored-by: Jason Runkle <jmrunkle@gmail.com>

Returns a copy of highScores collection instead of the original

99c203d

Co-authored-by: Jason Runkle <jmrunkle@gmail.com>

Returns a copy of the highScores collection

867208d

Co-authored-by: Jason Runkle <jmrunkle@gmail.com>

Base automatically changed from master to main January 28, 2021 19:15

jmrunkle closed this Sep 15, 2021

		@@ -0,0 +1,21 @@
		class HighScores {
		public HighScores(int[] highScores) {

Uh oh!

Conversation

CodeMartian commented Oct 4, 2019 • edited by jmrunkle Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lemoncurry left a comment

Choose a reason for hiding this comment

Uh oh!

CodeMartian commented Oct 16, 2019

Uh oh!

bmuskalla commented Oct 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmrunkle commented Apr 14, 2020

Uh oh!

jmrunkle commented Apr 22, 2020

Uh oh!

Uh oh!

jmrunkle Apr 22, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jmrunkle Apr 22, 2020

Choose a reason for hiding this comment

Uh oh!

jmrunkle Apr 22, 2020

Choose a reason for hiding this comment

Uh oh!

jmrunkle Apr 22, 2020

Choose a reason for hiding this comment

Uh oh!

jmrunkle Apr 22, 2020

Choose a reason for hiding this comment

Uh oh!

jmrunkle Apr 22, 2020

Choose a reason for hiding this comment

Uh oh!

jmrunkle Apr 22, 2020

Choose a reason for hiding this comment

Uh oh!

jmrunkle commented Apr 26, 2020

Uh oh!

IA-JeffMartian commented Apr 28, 2020

Uh oh!

jmrunkle commented Sep 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CodeMartian commented Oct 4, 2019 •

edited by jmrunkle

Loading

bmuskalla commented Oct 16, 2019 •

edited

Loading