Implement Camicia Practice Exercise#3105
Implement Camicia Practice Exercise#3105thibault2705 wants to merge 19 commits intoexercism:mainfrom
Conversation
thibault2705
force-pushed
the
camicia-exercice
branch
from
4cdf6a8 to
c15e3fe
Compare
jagdish-15
left a comment
jagdish-15
left a comment
There was a problem hiding this comment.
Adding a trailing newline will resolve the Checkstyle error.
| */ | ||
| private record RoundResult(Player nextStarter, int pileSize) { | ||
| } | ||
| } No newline at end of file |
| assertEquals(474, camicia.getCards()); | ||
| assertEquals(66, camicia.getTricks()); | ||
| } | ||
| } No newline at end of file |
| int getTricks() { | ||
| throw new UnsupportedOperationException("Delete this statement and write your own implementation."); | ||
| } | ||
| } No newline at end of file |
|
|
||
| private Camicia simulateGame(List<String> playerA, List<String> playerB) { | ||
| Camicia camicia = new Camicia(); | ||
| camicia.simulateGame(playerA, playerB); |
There was a problem hiding this comment.
Personally, I find it strange having to make an instance just to call the test method. Instead, could simulateGame be static (so the test doesn't need to make a new Camaicia())?. The status, cards and tricks could be returned in a separate record so that the tests can check them.
| assertEquals(1, camicia.getTricks()); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
Each test except the first should have the @Disabled("Remove to run test") annotation. See Bob for example.
| @@ -0,0 +1,6 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip | |||
There was a problem hiding this comment.
This looks like an older version of Gradle (we have been using Gradle 9.3.1 on the other exercises). Perhaps copy the Gradle files from one of the other exercises.
| { | ||
| "authors": [], | ||
| "contributors": [ | ||
| "thibault2705" |
There was a problem hiding this comment.
You should be the "author" instead of "contributor" (generally, the one who adds the exercise is the author and contributor is someone who updates after it has been added)
3 participants
pull request
Implement Camicia practice exercise specified in camicia/instructions.md.
This PR solves the task #3010.
Reviewer Resources:
Track Policies