Skip to content

Conversation

@Cool-Katt
Copy link
Contributor

Adding pop-count exercise to the js track

@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 25, 2024
@iHiD iHiD requested a review from ErikSchierboom January 25, 2024 16:41
@iHiD iHiD reopened this Jan 25, 2024
Copy link
Member

@IsaacG IsaacG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left comments that may very well be outside the scope of this PR.

There are some checks which are failing.

@@ -0,0 +1,5 @@
/node_modules
/bin/configlet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this file auto-created? It looks ... wrong. These ought to be in the root ignore file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an auto-generated file.

@@ -0,0 +1 @@
audit=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also defined in the root and I suspect isn't needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another auto-generated file.

@@ -0,0 +1,21 @@
MIT License
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Licensing is done on a repo level, not an exercise level.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yet another auto-generated file.

@Cool-Katt
Copy link
Contributor Author

All of the issues that @IsaacG pointed to are with auto-generated files. The command used to get those was ASSIGNMENT=pop-count npx babel-node scripts/sync I think, from the CONTRIBUTING.md. I've not messed with those, as i don't know if they're actually needed.

I also ran through the CI checks and it was all formatting errors. Should be all cleared after the last commit, if you can run them again.

@github-actions
Copy link
Contributor

The "Sync all exercises" action has started running.

@github-actions
Copy link
Contributor

The "Sync all exercises" action has finished running.

@github-actions
Copy link
Contributor

For security reasons, /sync does not trigger CI builds when the PR has been submitted from a fork. If checks were not passing due to code format, trigger a build to make the required checks pass, through one of the following ways:

  • Push an empty commit to this branch: git commit --allow-empty -m "Trigger builds".
  • Close and reopen the PR.
  • Push a regular commit to this branch.

@IsaacG IsaacG closed this Jan 26, 2024
@IsaacG IsaacG reopened this Jan 26, 2024
Comment on lines +4 to +8
"author": "Katrina Owen",
"contributors": [
"Derk-Jan Karrenbeld <derk-jan+git@karrenbeld.info> (https://derk-jan.com)",
"Tejas Bubane (https://tejasbubane.github.io/)"
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cool-Katt Do you want to update these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean to add myself as a contributor? I don't know if I properly understand what you mean.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Or as the author. The only person that worked on this exercise is you so I think it ought to be reflected in the author/contributors docs.

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ErikSchierboom ErikSchierboom merged commit b3b5242 into exercism:main Jan 28, 2024
@Cool-Katt Cool-Katt deleted the pop-count branch January 29, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants