-
-
Notifications
You must be signed in to change notification settings - Fork 654
[New practice exercise] Pop count #2373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left comments that may very well be outside the scope of this PR.
There are some checks which are failing.
| @@ -0,0 +1,5 @@ | |||
| /node_modules | |||
| /bin/configlet | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this file auto-created? It looks ... wrong. These ought to be in the root ignore file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an auto-generated file.
| @@ -0,0 +1 @@ | |||
| audit=false | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also defined in the root and I suspect isn't needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another auto-generated file.
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Licensing is done on a repo level, not an exercise level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yet another auto-generated file.
|
All of the issues that @IsaacG pointed to are with auto-generated files. The command used to get those was I also ran through the CI checks and it was all formatting errors. Should be all cleared after the last commit, if you can run them again. |
|
The "Sync all exercises" action has started running. |
|
The "Sync all exercises" action has finished running. |
|
For security reasons,
|
| "author": "Katrina Owen", | ||
| "contributors": [ | ||
| "Derk-Jan Karrenbeld <derk-jan+git@karrenbeld.info> (https://derk-jan.com)", | ||
| "Tejas Bubane (https://tejasbubane.github.io/)" | ||
| ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Cool-Katt Do you want to update these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean to add myself as a contributor? I don't know if I properly understand what you mean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. Or as the author. The only person that worked on this exercise is you so I think it ought to be reflected in the author/contributors docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Adding pop-count exercise to the js track