port proverb exercise from javascript track #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skabbass1
commented
Aug 15, 2017
exercises/proverb/proverb.spec.js
Outdated
|
|
||
| expect(result).toEqual( | ||
| 'For want of a nail the shoe was lost.\n' + | ||
| 'For want of a shoe the horse was lost.\n' + |
Contributor
Author
There was a problem hiding this comment.
Probably better to put multiple line strings in a string template literal rather than explicitly concatenating new line strings. What do you guys think?
Contributor
There was a problem hiding this comment.
It would make use of a ES6 feature, nice!
Just, be aware of spaces. The multiline string probably needs to be this way:
expect(result).toEqual(
`For want of a nail the shoe was lost.
For want of a show the horse was lost.
...`
Contributor
Author
There was a problem hiding this comment.
Yep. Will switch to string template literals and amend the commit
Contributor
|
Nice clean implementation. Well done. |
skabbass1
force-pushed
the
add-exercise-proverb
branch
from
e67504b to
7f24d45
Compare
tejasbubane
reviewed
Aug 19, 2017
exercises/proverb/example.js
Outdated
| return chainOfEvents.join('\n'); | ||
| }; | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
nitpick: keep single blank lines for consitency. The ones on the top of this file can be removed.
Contributor
Author
There was a problem hiding this comment.
Will do. Thanks for pointing it out.
tejasbubane
reviewed
Aug 19, 2017
exercises/proverb/proverb.spec.js
Outdated
| expect(proverb('nail', 'shoe')).toEqual(proverb('nail', 'shoe')); | ||
| }); | ||
|
|
||
|
|
tejasbubane
reviewed
Aug 21, 2017
exercises/proverb/proverb.spec.js
Outdated
| import proverb from './proverb'; | ||
|
|
||
|
|
||
| describe('Proverb xtest Suite', () => { |
skabbass1
force-pushed
the
add-exercise-proverb
branch
from
7f24d45 to
256674d
Compare
skabbass1
force-pushed
the
add-exercise-proverb
branch
from
256674d to
59638b0
Compare
Contributor
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a new pull request with the code changes for this exercise. I closed the old one because the git commit history for the branch associated with previous pull request did not look clean after the merge with master:
commit accd83f0e63d522f6ee1876637ed86cf952575cc
Merge: 242942b d1d8a82
Author: sabbas syed.k.abbas1988@gmail.com
Date: Tue Aug 15 06:20:46 2017 -0500
commit d1d8a82
Author: Syed Abbas syed.k.abbas1988@gmail.com
Date: Thu Aug 10 14:02:19 2017 -0500
commit 242942b
Author: sabbas syed.k.abbas1988@gmail.com
Date: Thu Aug 10 07:09:53 2017 -0500
This is probably because I created an empty pull request for the proverb exercises before the run-length-encoding pull request was merged into master: