-
-
Notifications
You must be signed in to change notification settings - Fork 205
issues 310: Create stub files for all exercises #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Why are the tests un-ignored? Only the first test should be enabled. IMO, the stub does not need to compile, but I think it's find to give a stub without a default argument. It's a pretty natural path to add a default argument as you go. As for the rest:
|
|
All questionable things are undone. We stll cannot get this compiled until PR 318 is merged. |
|
Yes. @uzilan mentioned it on the Slack :)! Thanks for your work @eparovyshnaya 🎉 |
exercises/secret-handshake/src/main/kotlin/HandshakeCalculator.kt
Outdated
Show resolved
Hide resolved
exercises/secret-handshake/src/main/kotlin/HandshakeCalculator.kt
Outdated
Show resolved
Hide resolved
If you show me what that would look like... sure :) |
|
Nice! Don't use KDoc for this, but the TrackInsert hint! Then, readme needs to be re-generated. The hint will become part of Yes, use |
|
Got it. Will remove the KDocs from both stubs to call it a day for this PR. Will open another one for TrackHints. |
SleeplessByte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@exercism/kotlin please merge 🤗
dector
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Please, squash into single commits and merge.
|
@dector if you squash-merge here, those steps are unnecessary. |
|
@SleeplessByte Kinda. I'm not using built-in functionality here intentionally. There is no rush for this PR so I suggested to do it manually. |
|
Guys, I do appreciate your help and care. Just let me sort it out. Taming this rebase became an affair of honor for me. |
|
@dector, made it. Can you please merge? |
The stub is questionable if the following aspects.
It contains hints to study about
It does not contain a clue for default arguments. I just do not know how to mention it withount giving a precise solution.
It is quite a Kotlin-like, but I'm not sure if it fits Exercism studying methodics.
Do you wish the stub to stay as close to the reference solution as possibl?
Do you want to avoid distraction by extra study motivators (like internal keyword and = sign in a function signture)?
If you do, I will rework the stub for sure.
If you don't, I have anoher proposal: can I add these links in the function's kotlin-doc?