lakefile now accepts an extra file#13
Merged
oxe-i merged 2 commits intoexercism:mainfrom Apr 12, 2026
Merged
Conversation
keiravillekode
approved these changes
Apr 11, 2026
Contributor
keiravillekode
left a comment
There was a problem hiding this comment.
Some additional context motivating this change is in
Contributor
Author
|
@exercism/guardians just in case the notification got lost |
IsaacG
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--wfailtolake testto treat warnings as errors.lakefile.tomlso that it accepts an extra file calledExtra.lean.For performance reasons, we don't use the exercises'
lakefile.tomlin the test runner. This is because we pre-build some modules to reduce build times during tests.However, once
lakefile.tomlchanges, lake recompiles all the modules, so, in order to pre-build, we must have a generic lakefile that is used when creating the test-runner docker image and again to test every exercise.This generic
lakefile.tomlcurrently has a structure that only accepts the solution file and the test files, making it impossible to implement exercises that accept extra modules. This PR fixes that by adding an extraExtra.leanmodule to the lakefile.While doing that, I've also added
--wfailtolake testand an extra configuration tolakefile.toml. Both serve to treat warnings as errors, making the build to fail. This is necessary in some exercises and good practice in the others.