Skip to content

Conversation

@bencoman
Copy link
Contributor

Example custom Quality Assistant rule for reuse in TwoFer

@macta
Copy link
Contributor

macta commented May 11, 2019

Nice! Haven't tested it yet - but looks good. Does it present itself as a yellow triangle - or do you have to run the critic?

Armed with some of these - we can plug these into the auto-mentor project (I think we need to work out a docker vm or something, to run an image cmd line to answer the results of our critics). I'd held off as I felt we ought to get our other bits sorted first - however having some of these in place will make it super easy. Thanks for chasing.

@macta
Copy link
Contributor

macta commented May 16, 2019

It's really nice @bencoman - we could consider offering to run our exercism tool critics before a submit as well (essentially their auto-mentor locally)

@macta
Copy link
Contributor

macta commented May 16, 2019

While we're on a critic role - I'll commit it (we may want to move them to a new ExercismCritic package if we do a few more)

@macta macta merged commit 4ddd170 into exercism:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants