Sync poker (issue #992)

[resu-xuniL]

• Synced Poker metadata and docs
• Removed strict types comments from example.php and PokerTest.php
• Added UUID and TestDox to tests
• Added poker to auto-sync.txt
• Added GitHub handle to config.json

Had to modify example.php to pass new test cases from problem-specifications

Ref: #992

Closes #992

[github-actions]

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

[mk-mxp]

What a bad interface for students :( Anyways, that's how it is.

Do you remember, which tests broke and what test caused which change to the examples? You have only one commit with all changes, so I cannot see that relationship.

I will have to take a closer look at the test cases later for a decision about adding them / breaking existing solutions or keeping the existing solutions valid / skipping tests.

[mk-mxp]

OK, let's break things (you don't have to change the code). Only 29% of 198 students solved the exercise so far, resulting in only 58 community solutions. That's not none, but a high failure rate is also no good sign.

I still do not want to change the interface, even if a function would be my preferred choice. I'd rather add a comment requesting "Property hooks" as we did in high-scores.

I suggest to also raise the difficulty to 7, lowest hard level. The exercise is quite big, it basically covers all Poker rules. One should not have any trouble with PHP anymore before trying it.

Thank you!

[resu-xuniL]

Ok !
And as I wanna be sure to understand what you want me to do, please confirm :

1. no (more) change at all in example.php and pokerTest.php (ie. we keep all the modifications that I already made in these both files).
2. we add the comment requesting "Property hooks" (as in high-scores) in Poker.php
3. what about the comment for data encapsulation as in GameOfLife.php ?
4. raise the difficulty to 7

Thanks !

[mk-mxp]

• To 1.: Yes. These are OK.
• To 2. and 3: The "Asymetric Visibility" and the "Property hooks" are both enhancing the data encapsulation. I'd ask for "Property hooks" because one can stop doing all the work in the constructor (which is bad design) and do "on-demand calculation" of the result. You can add both, but I'd prefer "Property hooks".
• To 4.: Yes.

[resu-xuniL]

Hope everything is correct! :)