Skip to content

Sync matrix#955

Merged
mk-mxp merged 21 commits intoexercism:mainfrom
Narkunan:sync-matrix
Apr 26, 2026
Merged

Sync matrix#955
mk-mxp merged 21 commits intoexercism:mainfrom
Narkunan:sync-matrix

Conversation

@Narkunan
Copy link
Copy Markdown
Contributor

Fix issue #923

@github-actions
Copy link
Copy Markdown

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@Narkunan
Copy link
Copy Markdown
Contributor Author

@mk-mxp Sorry I faced some sync with previous PR so created a new one. Please provide your feedback. I am happy to work on them

@mk-mxp
Copy link
Copy Markdown
Contributor

mk-mxp commented Apr 26, 2026

@Narkunan To avoid that kind of trouble, you can follow these steps:

  • Before starting a PR, create a branch on your fork and commit to it (you did this already, I think)
  • Open the PR from the new branch to main here (you also did this, I believe)
  • After a PR was merged, first delete your branch using the button below the merged PR's discussion - this deletes the branch from your GitHub fork
  • Then sync your fork to this repository again - this updates main of your fork
  • Then sync your local git repository using git checkout main and git pull -p - this updates main and deletes the remote branch configuration
  • At last, delete the local branch using git branch -D $YOUR_BRANCH

This workflow keeps your local copy as close as possible to the Exercism main branch and tidies it up. I'm now reading through your changes...

Copy link
Copy Markdown
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for investing the time to sync this! Please take a look at the test data, too, before you submit the next exercise. The differences are everywhere...

Comment thread exercises/practice/matrix/.meta/config.json Outdated
Comment thread exercises/practice/matrix/MatrixTest.php Outdated
Comment thread exercises/practice/matrix/MatrixTest.php Outdated
@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/tiny Tiny amount of work x:rep/tiny Tiny amount of reputation x:size/small Small amount of work and removed x:size/tiny Tiny amount of work x:rep/tiny Tiny amount of reputation labels Apr 26, 2026
@mk-mxp mk-mxp added the x:rep/small Small amount of reputation label Apr 26, 2026
@Narkunan Narkunan requested a review from mk-mxp April 26, 2026 12:53
Copy link
Copy Markdown
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of misunderstanding, I see. The comment block in the students code (Matrix.php) is wanted, the other two (example.php and MatrixTest.php) shall go.

Comment thread exercises/practice/matrix/Matrix.php
Comment thread phpcs.xml Outdated
@Narkunan Narkunan requested a review from mk-mxp April 26, 2026 16:03
Copy link
Copy Markdown
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution! Looking forward to the next exercise.

@mk-mxp mk-mxp merged commit e1574cc into exercism:main Apr 26, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants