Skip to content

Queen attack#970

Merged
mk-mxp merged 9 commits into
exercism:mainfrom
A-O-Emmanuel:queen-attack
May 25, 2026
Merged

Queen attack#970
mk-mxp merged 9 commits into
exercism:mainfrom
A-O-Emmanuel:queen-attack

Conversation

@A-O-Emmanuel
Copy link
Copy Markdown
Contributor

This pull request does the following:

Sync test files and meta data to problem specification

Drop strict types comments from test file and example code

Add and sync test meta data to tests (uuid in DocBlocks / #TestDox())

Add exercise to bin/auto-sync.txt to keep it in sync (keep the file alphabetically sorted)

Adding / adjust / ordering test cases to match current problem specs

Add missing test case

@github-actions
Copy link
Copy Markdown

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@A-O-Emmanuel A-O-Emmanuel mentioned this pull request May 23, 2026
6 tasks
@mk-mxp mk-mxp self-requested a review May 24, 2026 08:19
@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/tiny Tiny amount of work x:rep/tiny Tiny amount of reputation labels May 24, 2026
Comment thread exercises/practice/palindrome-products/PalindromeProductsTest.php
Comment thread exercises/practice/queen-attack/QueenAttackTest.php Outdated
Comment thread exercises/practice/queen-attack/QueenAttackTest.php Outdated
Comment thread exercises/practice/queen-attack/QueenAttackTest.php Outdated
Comment thread exercises/practice/queen-attack/QueenAttackTest.php Outdated
@A-O-Emmanuel A-O-Emmanuel requested a review from mk-mxp May 25, 2026 01:59
Copy link
Copy Markdown
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investing so much time and effort! Only 2 little whitespace issues left before merging.

Comment thread exercises/practice/queen-attack/QueenAttackTest.php Outdated
Comment thread exercises/practice/queen-attack/QueenAttackTest.php Outdated
@mk-mxp mk-mxp added x:size/small Small amount of work x:rep/small Small amount of reputation and removed x:size/tiny Tiny amount of work x:rep/tiny Tiny amount of reputation labels May 25, 2026
A-O-Emmanuel and others added 2 commits May 25, 2026 16:59
Co-authored-by: mk-mxp <55182845+mk-mxp@users.noreply.github.com>
Co-authored-by: mk-mxp <55182845+mk-mxp@users.noreply.github.com>
@A-O-Emmanuel
Copy link
Copy Markdown
Contributor Author

Hi @mk-mxp my pleasure, I learn a lot doing these

@A-O-Emmanuel A-O-Emmanuel requested a review from mk-mxp May 25, 2026 16:03
Copy link
Copy Markdown
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for helping!

@mk-mxp mk-mxp merged commit b715c0d into exercism:main May 25, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants