Skip to content

Phone number: Correct the format #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Phone number: Correct the format #2317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions exercises/phone-number/description.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,14 @@ The first three digits of the local number represent the *exchange code*, follow
The format is usually represented as

```text
(NXX)-NXX-XXXX
NXX NXX-XXXX
Copy link
Member

@kotp kotp Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might show both that are often used...

The tests are not going to differentiate in a way that errors, but will present it as a cleaned version.

Here we are showing what is "usually" represented, and I might think that

(NXX) NXX-XXXX

And

(NXX)NXX-XXXX

are pretty evenly tied in the usual use.

I totally agree with using either with parenthesis or or dash to separate the area code from either or both sides of that, never both at the same time.

Copy link
Member

@IsaacG IsaacG Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also change "usually" to "sometimes" and not worry about what is commonly used where 😄

```

where `N` is any digit from 2 through 9 and `X` is any digit from 0 through 9.

Your task is to clean up differently formatted telephone numbers by removing punctuation and the country code (1) if present.
Sometimes they also have the country code (represented as `1` or `+1`) prefixed.

Your task is to clean up differently formatted telephone numbers by removing punctuation and the country code if present.

For example, the inputs

Expand Down