Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
|
I removed the unnecessary tests. I left only two tests with floating-point precision. |
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
|
There's a problem with CI. I have no idea what it is. A link is broken (?) |
Yeah. But it's in the |
There was a problem hiding this comment.
Pull request overview
This PR adds a new exercise called "Prism" to the problem-specifications repository. The exercise involves calculating the path of a laser beam through a field of reflective crystal prisms, where each prism redirects the beam by a specified angle. Students must predict the sequence of crystals that will be hit by the laser.
Changes:
- Added metadata, introduction, instructions, and canonical test data for the new "Prism" exercise
- Includes 14 test cases covering edge cases (no prisms, single prism, directional tests) and complex multi-prism scenarios with floating-point precision
- Provides a detailed walkthrough example explaining how the laser beam interacts with the prisms
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| exercises/prism/metadata.toml | Defines exercise metadata including title, blurb, source attribution, and source URL |
| exercises/prism/introduction.md | Provides story context about PRISM (Precariously Redirected Illumination Safety Management) laser calibration system |
| exercises/prism/instructions.md | Contains detailed instructions with an example test case and step-by-step walkthrough of beam behavior |
| exercises/prism/canonical-data.json | Defines 14 test cases with standardized inputs and expected outputs for the findSequence property |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Who asked copilot to chime in? Wow, did that create spam in my inbox. |
|
I removed the PR from the drafts, maybe that was what triggered it. @BethanyG |
|
I made an example CoffeeScript implementation at exercism/coffeescript#404. The exercise seems like a good addition. |
Co-authored-by: András B Nagy <20251272+BNAndras@users.noreply.github.com>
|
+cc @ErikSchierboom for final approval |
https://forum.exercism.org/t/new-exercise-proposal-prism/26302