Skip to content

fix: argument name order mismatch with tests in rna_transcription.pl#457

Merged
ErikSchierboom merged 1 commit intoexercism:mainfrom
anarcal:patch-1
Mar 16, 2025
Merged

fix: argument name order mismatch with tests in rna_transcription.pl#457
ErikSchierboom merged 1 commit intoexercism:mainfrom
anarcal:patch-1

Conversation

@anarcal
Copy link
Contributor

@anarcal anarcal commented Mar 16, 2025

The following tests imply that the second argument is an RNA sequence, since only RNA has U base pairs. All the tests work if you just swap the initial order of the arguments, and implement the conversion correctly.

    test(rna_complement_of_adenine_is_uracil, condition(pending)) :-
        rna_transcription("A", Result),
        Result == "U".

    test(rna_complement, condition(pending)) :-
        rna_transcription("ACGTGGTCTTAA", Result),
        Result == "UGCACCAGAAUU".

@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Mar 16, 2025
@ErikSchierboom ErikSchierboom merged commit 7309f66 into exercism:main Mar 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants