Skip to content

Conversation

@senekor
Copy link
Contributor

@senekor senekor commented Feb 2, 2023

Most of the warnings relate to idiomatic format strings. I think these warnings were introduced with Rust 1.67.

variables can be used directly in the `format!` string
for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
`#[warn(clippy::uninlined_format_args)]` on by default

There is one other warning I fixed about lifetimes that can be elided.

There are still a couple warnings about a new function without a default implementation. I didn't do anything about those because it seemed unclear to me what the best thing to do is.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Feb 2, 2023
@ErikSchierboom
Copy link
Member

@remlse I can't re-open this PR. Could you open another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants