poker: improve test robustness for ranking pairs/triplets #1642
Conversation
Increased rank of losing hand's lone cards or decreased rank of winning hand's pair/triplet. This allows the tests to fail if the triplets'/pairs' ranks aren't compared first. Modified-by: Joel Kappes <jkappes@comtexing.de>
|
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
these need to be submitted to https://github.com/exercism/problem-specifications/blob/main/exercises/poker/canonical-data.json, not just to the Rust track. The Rust track cannot afford to gain a reputation of being selfish and only keeping our changes to ourselves. We share with others and give back to others.
2 participants
Increased rank of losing hand's lone cards or decreased rank of winning hand's pair/triplet.
This allows the tests to fail if the triplets'/pairs' ranks aren't compared first.
Modified-by: Joel Kappes jkappes@comtexing.de