Skip to content

Conversation

@senekor
Copy link
Contributor

@senekor senekor commented Feb 22, 2025

stacked on #2035

@senekor senekor requested a review from ellnix February 22, 2025 00:41
Base automatically changed from senekor/rwkxpuuyorvl to main February 22, 2025 00:44
@senekor senekor force-pushed the senekor/suxxmpvxpklu branch from 5bac850 to 223dcca Compare February 22, 2025 00:47
@ellnix
Copy link
Contributor

ellnix commented Feb 22, 2025

A quick fd reveals these are the only Rust files with dashes in them:

exercises/practice/macros/tests/invalid/comma-sep.rs
exercises/practice/macros/tests/invalid/double-commas.rs
exercises/practice/macros/tests/invalid/leading-comma.rs
exercises/practice/macros/tests/invalid/missing-argument.rs
exercises/practice/macros/tests/invalid/no-comma.rs
exercises/practice/macros/tests/invalid/only-arrow.rs
exercises/practice/macros/tests/invalid/only-comma.rs
exercises/practice/macros/tests/invalid/single-argument.rs
exercises/practice/macros/tests/invalid/triple-arguments.rs
exercises/practice/macros/tests/invalid/two-arrows.rs

We can let them be, or fix them. I don't mind in any case.

I'll do a few tests on the tooling and probably approve.

@senekor
Copy link
Contributor Author

senekor commented Feb 22, 2025

good catch, gonna fix those

Copy link
Contributor

@ellnix ellnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find anything wrong with it. LGTM!

@senekor senekor merged commit 88c13fb into main Feb 22, 2025
10 checks passed
@senekor senekor deleted the senekor/suxxmpvxpklu branch February 22, 2025 01:11
senekor added a commit to exercism/rust-test-runner that referenced this pull request Feb 25, 2025
The test files were renamed to use snake case in:
exercism/rust#2036
senekor added a commit to exercism/rust-test-runner that referenced this pull request Feb 27, 2025
The test files were renamed to use snake case in:
exercism/rust#2036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants